[Kde-pim] Review Request 126395: Fix crash when kmail exits

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126395/#review89644
-----------------------------------------------------------

Ship it!


Thanks for the patch, it looks good. I've been testing something very similar locally :) Just a minor comment, please fix it before comitting.


akonadi/src/core/session_p.h (line 142)
<https://git.reviewboard.kde.org/r/126395/#comment61394>

    Could you rename it to connThreadCleanup, and move it next to where connThread is declared? Just to make it more obvious what this belongs to...


- Daniel Vrátil


On Dec. 16, 2015, 10:12 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126395/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 10:12 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Daniel Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> The lambda function used in signal connection need to be handled carefully. SessionPrivate may be already deleted, but the signal is fired afterwards. Since SessionPrivate is not a QObject and Session is created after SessionPrivate, use QMetaObject::Connection to disconnect the connection on aboutToQuit in destructor.
> 
> 
> Diffs
> -----
> 
>   akonadi/src/core/session.cpp 4711bf5 
>   akonadi/src/core/session_p.h a61b2f7 
> 
> Diff: https://git.reviewboard.kde.org/r/126395/diff/
> 
> 
> Testing
> -------
> 
> No more crash
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/