[Kde-pim] Review Request 126395: Fix crash when kmail exits

Xuetian Weng wengxt at gmail.com
Thu Dec 17 16:21:44 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126395/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 4:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Daniel Vrátil.


Changes
-------

Submitted with commit c6bf33a9018587e96a350bfd0b2bffde1859db27 by Weng Xuetian to branch Applications/15.12.


Repository: kdepimlibs


Description
-------

The lambda function used in signal connection need to be handled carefully. SessionPrivate may be already deleted, but the signal is fired afterwards. Since SessionPrivate is not a QObject and Session is created after SessionPrivate, use QMetaObject::Connection to disconnect the connection on aboutToQuit in destructor.


Diffs
-----

  akonadi/src/core/session.cpp 4711bf5 
  akonadi/src/core/session_p.h a61b2f7 

Diff: https://git.reviewboard.kde.org/r/126395/diff/


Testing
-------

No more crash


Thanks,

Xuetian Weng

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list