[Kde-pim] Review Request 124725: keep private libs as private as possible by not installing a namelink

[Laurent Montel]

> On août 13, 2015, 9:53 matin, Daniel Vrátil wrote:
> > Looks good to me. Laurent?

Indeed seems good for me.
If you push in 15.08 we will merge in master after that.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124725/#review83763
-----------------------------------------------------------


On août 13, 2015, 9:48 matin, Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124725/
> -----------------------------------------------------------
> 
> (Updated août 13, 2015, 9:48 matin)
> 
> 
> Review request for KDEPIM, Daniel Vrátil and Laurent Montel.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> there are no headers being installed for resource libraries so they cannot
> be linked anyway, so we can also skip the namelink creation (.so symlink)
> 
> 
> Diffs
> -----
> 
>   resources/folderarchivesettings/CMakeLists.txt 6ca0d32701505dc5d0dd4eec37e6c81b00d70bd2 
>   resources/shared/singlefileresource/CMakeLists.txt 2cb43dc316109d05cdbfd2830644f2efcde86103 
>   resources/shared/filestore/CMakeLists.txt 2b593b1ecc8e9873a3230ac889f65d5e479a2ae2 
>   resources/mixedmaildir/kmindexreader/CMakeLists.txt 186ebc7fff8049d8ee14e491c2d8236722f0762d 
>   resources/mixedmaildir/CMakeLists.txt def56296fe7cbe94e6e0a4eab83a6565086a3cf7 
>   resources/maildir/libmaildir/CMakeLists.txt 7dd52fd23bed8dfd0e5031ad022f04230a9bf29f 
> 
> Diff: https://git.reviewboard.kde.org/r/124725/diff/
> 
> 
> Testing
> -------
> 
> built; doesn't install symlinks anymore
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/