[Kde-pim] Review Request 120447: [IMAP] Remove RemoveItemTask and use ChangeItemsFlagsTask to handle item removal

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120447/
-----------------------------------------------------------

(Updated Oct. 3, 2014, 9:15 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Christian Mollekopf.


Bugs: 339565
    http://bugs.kde.org/show_bug.cgi?id=339565


Repository: kdepim-runtime


Description
-------

Since item removal only means adding \Deleted flag to the email, we can just use ChangeItemsFlagsTask to do this for us. RemoveItemsTask is just a dumbeder ChangeItemsFlagsTask with hardcoded flag to append, so by removing the class, we remove a bit of duplicated code.

This also means that fixes and changes we do to flags changes will automatically be applied to item removal too (see review /r/120446 for example)


Diffs
-----

  resources/imap/CMakeLists.txt 89bbf65 
  resources/imap/imapresourcebase.cpp 62d5031 
  resources/imap/removeitemstask.h 800ddde 
  resources/imap/removeitemstask.cpp 300ff43 
  resources/imap/tests/CMakeLists.txt 92867ed 
  resources/imap/tests/testremoveitemstask.cpp bc446ef 

Diff: https://git.reviewboard.kde.org/r/120447/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/