[Kde-pim] Review Request 120982: Rename KABC to KContacts

Aleix Pol Gonzalez aleixpol at kde.org
Wed Nov 5 18:08:20 GMT 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120982/
-----------------------------------------------------------

(Updated Nov. 5, 2014, 6:08 p.m.)


Review request for KDEPIM-Libraries.


Changes
-------

Full port of all kdepimlibs.

Here's a porting script: http://paste.kde.org/p1acawdkv


Repository: kdepimlibs


Description
-------

When looking into what needs to be done to get kabc released, I was suggested to rename it into something else. In this patch I'm suggesting to rename it to KContacts.


Diffs (updated)
-----

  kcalcore/src/person.cpp 61409d6 
  kabc/tests/testread.cpp 288db76 
  kabc/tests/testread2.cpp 045056a 
  kabc/tests/testutils.h b8d5cc6 
  kabc/tests/testutils.cpp f6f5821 
  kabc/tests/testwrite.cpp c9034f3 
  kabc/src/sortmode.h 36be9c8 
  kabc/src/sortmode.cpp 7477ce4 
  kabc/src/sound.h 2a7d205 
  kabc/src/sound.cpp 5e399cb 
  kabc/src/timezone.h 8311c5b 
  kabc/src/timezone.cpp 9c7ae1d 
  kabc/src/vcardconverter.h 4c19d0f 
  kabc/src/vcardconverter.cpp b7adb94 
  kabc/src/vcarddrag.h 11e0f4b 
  kabc/src/vcarddrag.cpp 69a7f42 
  kabc/src/vcardparser/CMakeLists.txt 7fb0c88 
  kabc/src/vcardparser/vcard.h 5153cfa 
  kabc/src/vcardparser/vcard.cpp e2600ec 
  kabc/src/vcardparser/vcardline.h 8290d7f 
  kabc/src/vcardparser/vcardline.cpp c495a33 
  kabc/src/vcardparser/vcardparser.h 3497642 
  kabc/src/vcardparser/vcardparser.cpp c2ae6d5 
  kabc/src/vcardtool.h 25a95e5 
  kabc/src/vcardtool.cpp 419c755 
  kabc/tests/CMakeLists.txt bd31124 
  kabc/tests/README.testing  
  kabc/tests/checkvcard.pl  
  kabc/src/phonenumber.cpp 84481dd 
  kabc/src/picture.h 3e9780f 
  kabc/src/picture.cpp 0ff7386 
  kabc/src/plugin.h 1f9005e 
  kabc/src/plugin.cpp d89c708 
  kabc/src/secrecy.h 33108b1 
  kabc/src/secrecy.cpp 968d3a5 
  kabc/autotests/bigread.cpp 442994d 
  kabc/autotests/bigwrite.cpp 40c56fc 
  kabc/autotests/contactgrouptest.cpp 831d480 
  kabc/autotests/data/v4_0.vcard1.vcf.ref  
  kabc/autotests/data/v4_0.vcard2.vcf.ref  
  kabc/autotests/data/v4_0.vcard3.vcf.ref  
  kabc/autotests/data/v4_0.vcard4.vcf.ref  
  kabc/autotests/data/v4_0.vcard5.vcf.ref  
  kabc/autotests/data/v4_0.vcard6.vcf.ref  
  kabc/autotests/data/v4_0.vcard7.vcf.ref  
  kabc/autotests/data/v4_0.vcard8.vcf.ref  
  kabc/autotests/data/vcard1.vcf  
  kabc/autotests/data/vcard1.vcf.ref  
  kabc/autotests/data/vcard10.vcf  
  kabc/autotests/data/vcard10.vcf.ref  
  kabc/autotests/data/vcard2.vcf  
  kabc/autotests/data/vcard2.vcf.ref  
  kabc/autotests/data/vcard3.vcf  
  kabc/autotests/data/vcard3.vcf.2_1ref  
  kabc/autotests/data/vcard3.vcf.ref  
  kabc/autotests/data/vcard4.vcf  
  kabc/autotests/data/vcard4.vcf.ref  
  kabc/autotests/data/vcard5.vcf  
  kabc/autotests/data/vcard5.vcf.ref  
  kabc/autotests/data/vcard6.vcf  
  kabc/autotests/data/vcard6.vcf.ref  
  kabc/autotests/data/vcard7.vcf  
  kabc/autotests/data/vcard7.vcf.ref  
  kabc/autotests/data/vcard8.vcf  
  kabc/autotests/data/vcard8.vcf.ref  
  kabc/autotests/data/vcard9.vcf  
  kabc/autotests/data/vcard9.vcf.ref  
  kabc/autotests/geotest.h 08665d0 
  kabc/autotests/geotest.cpp 4c10da2 
  kabc/autotests/kabcargl.cpp db3db9e 
  kabc/autotests/keytest.h adde49a 
  kabc/autotests/keytest.cpp bb83538 
  kabc/autotests/phonenumbertest.h ec4ba8d 
  kabc/autotests/phonenumbertest.cpp 3e55617 
  kabc/autotests/picturetest.h 15e11df 
  kabc/autotests/picturetest.cpp 143df82 
  kabc/autotests/secrecytest.h dccdf57 
  kabc/autotests/secrecytest.cpp d273bd1 
  kabc/autotests/soundtest.h 97adbc6 
  kabc/autotests/soundtest.cpp 3da1abc 
  kabc/autotests/testkabc.cpp 0f498b7 
  kabc/autotests/testkabcdlg.cpp d1365f4 
  kabc/autotests/testlock.h e49f1cd 
  kabc/autotests/testlock.cpp efbfb79 
  kabc/autotests/testroundtrip.cpp 28c444a 
  kabc/autotests/testroundtrip.qrc  
  kabc/autotests/timezonetest.h ce2d792 
  kabc/autotests/timezonetest.cpp d18c741 
  kabc/autotests/vcarddragtest.cpp 7980153 
  kabc/src/CMakeLists.txt 9c74903 
  kabc/src/Messages.sh ef2e128 
  kabc/src/address.h de079a6 
  kabc/src/address.cpp 046850b 
  kabc/src/addressee.h baa9e99 
  kabc/src/addressee.cpp 4d2f788 
  kabc/src/addresseehelper.h 84dad2a 
  kabc/src/addresseehelper.cpp 933fc1b 
  kabc/src/addresseelist.h 4ffe8db 
  kabc/src/addresseelist.cpp 1a9a64d 
  kabc/src/contactgroup.h 2a7a695 
  kabc/src/contactgroup.cpp 3e36521 
  kabc/src/contactgroup.xsd  
  kabc/src/contactgrouptool.h 83c8a91 
  kabc/src/contactgrouptool.cpp b45cefc 
  kabc/src/countrytransl.map  
  kabc/src/errorhandler.h 6a421dc 
  kabc/src/errorhandler.cpp 28aa360 
  kabc/src/field.h f917868 
  kabc/src/field.cpp 53a7345 
  kabc/src/geo.h 5d67562 
  kabc/src/geo.cpp 85adfbd 
  kabc/src/kabc_debug.h 202fc8f 
  kabc/src/key.h 8a1fbb9 
  kabc/src/key.cpp e8df5b7 
  kabc/src/ldapdn.cpp  
  kabc/src/ldapdn_p.h  
  kabc/src/ldif.cpp  
  kabc/src/ldif_p.h  
  kabc/src/ldifconverter.h d12bdbf 
  kabc/src/ldifconverter.cpp 059b46d 
  kabc/src/phonenumber.h cab5d6b 
  akonadi-contact/src/standardcontactgroupformatter.cpp 7fbbf16 
  akonadi/src/core/abstractdifferencesreporter.h 827155d 
  akonadi/src/core/itemmonitor.h 9224b05 
  akonadi/src/core/jobs/itemcreatejob.h e305f61 
  akonadi/src/core/jobs/recursiveitemfetchjob.h d8973f8 
  akonadi/src/core/mimetypechecker.h 1617b76 
  akonadi/src/core/models/entitytreemodel.h 9905f01 
  akonadi/src/widgets/collectioncombobox.h c0d2080 
  akonadi/src/widgets/collectiondialog.h 9e3a2ab 
  akonadi/tests/pluginloadertest.cpp 9b1d02b 
  kabc/.krazy  
  kabc/.reviewboardrc  
  akonadi-contact/src/editor/geoeditwidget.h 3fd93f7 
  akonadi-contact/src/editor/geoeditwidget.cpp ed39878 
  akonadi-contact/src/editor/imagewidget.h 1604e64 
  akonadi-contact/src/editor/imagewidget.cpp 0ef6ad9 
  akonadi-contact/src/editor/imeditwidget.h 642ee2f 
  akonadi-contact/src/editor/imeditwidget.cpp 36fea8f 
  akonadi-contact/src/editor/nameeditwidget.h 1e0292e 
  akonadi-contact/src/editor/nameeditwidget.cpp fbeba2e 
  akonadi-contact/src/editor/phoneeditwidget.h dfc791b 
  akonadi-contact/src/editor/phoneeditwidget.cpp 47484a6 
  akonadi-contact/src/editor/secrecyeditwidget.h 8d24195 
  akonadi-contact/src/editor/secrecyeditwidget.cpp 0305d03 
  akonadi-contact/src/editor/soundeditwidget.h 54c55fa 
  akonadi-contact/src/editor/soundeditwidget.cpp c3be4b3 
  akonadi-contact/src/emailaddressselection.cpp 50a96c3 
  akonadi-contact/src/emailaddressselectionproxymodel.cpp 946a2fd 
  akonadi-contact/src/emailaddressselectionwidget.cpp f447c00 
  akonadi-contact/src/standardcontactactionmanager.cpp a8c3900 
  akonadi-contact/src/standardcontactformatter.h 55a6d15 
  akonadi-contact/src/standardcontactformatter.cpp 25b4f91 
  akonadi-contact/src/standardcontactgroupformatter.h 101acf6 
  kabc/CMakeLists.txt d7b167d 
  kabc/COPYING.LIB  
  kabc/HACKING  
  kabc/HOWTO  
  kabc/KF5AbcConfig.cmake.in d521848 
  kabc/Mainpage.dox  
  kabc/README  
  kabc/README.AddressFormat  
  kabc/TODO  
  kabc/autotests/CMakeLists.txt 50968c9 
  kabc/autotests/addresseetest.h 6d5f7f0 
  kabc/autotests/addresseetest.cpp dd5cedb 
  kabc/autotests/addresstest.h 73bac83 
  kabc/autotests/addresstest.cpp 5ab44a3 
  akonadi-contact/src/editor/addresseditwidget.h 228de3c 
  akonadi-contact/src/editor/addresseditwidget.cpp 017cab5 
  akonadi-contact/src/editor/categorieseditwidget.h 5960d87 
  akonadi-contact/src/editor/categorieseditwidget.cpp 3834551 
  akonadi-contact/src/editor/contacteditorwidget.h f0353b2 
  akonadi-contact/src/editor/contacteditorwidget.cpp 1f0c731 
  akonadi-contact/src/editor/customfieldseditwidget.h 95b3979 
  akonadi-contact/src/editor/customfieldseditwidget.cpp 4243b24 
  akonadi-contact/src/editor/displaynameeditwidget.h 8a7c41d 
  akonadi-contact/src/editor/displaynameeditwidget.cpp 82d5ed4 
  akonadi-contact/src/editor/emaileditwidget.h aa36212 
  akonadi-contact/src/editor/emaileditwidget.cpp 5ee1678 
  akonadi-contact/src/editor/freebusyeditwidget.h 00853af 
  akonadi-contact/src/editor/freebusyeditwidget.cpp a6f383c 
  akonadi-contact/src/contactviewer.cpp 4a62308 
  akonadi-contact/src/contactviewerdialog.h 2a45727 
  akonadi-contact/src/contactstreemodel.cpp 352309a 
  akonadi-contact/src/contactviewer.h 7c617c7 
  akonadi-contact/src/contactstreemodel.h bdfa4aa 
  akonadi-contact/src/contactgroupeditor_p.h b0392ff 
  akonadi-contact/src/contactgroupeditordialog.cpp 59a613f 
  akonadi-contact/src/contactgroupexpandjob.h bad59c2 
  akonadi-contact/src/contactgroupexpandjob.cpp 5745d04 
  akonadi-contact/src/contactgrouplineedit.cpp 9a47784 
  akonadi-contact/src/contactgrouplineedit_p.h b5425e5 
  akonadi-contact/src/contactgroupmodel.cpp afd896a 
  akonadi-contact/src/contactgroupmodel_p.h 1cab8a7 
  akonadi-contact/src/contactgroupsearchjob.h b00d57b 
  akonadi-contact/src/contactgroupsearchjob.cpp b62af24 
  akonadi-contact/src/contactgroupviewer.cpp 39507e2 
  akonadi-contact/src/contactsearchjob.h b533977 
  akonadi-contact/src/contactsearchjob.cpp 6535ad1 
  akonadi-contact/src/contactsfilterproxymodel.cpp fbcc991 
  akonadi-contact/src/contactgroupeditor.h 7b9a8c0 
  akonadi-contact/src/contactgroupeditor.cpp 5afe6f3 
  CMakeLists.txt 0a6a246 
  akonadi-calendar/src/freebusymanager.cpp 888d32e 
  akonadi-contact/src/CMakeLists.txt 431d3a1 
  akonadi-contact/src/abstractcontacteditorwidget_p.h e87c113 
  akonadi-contact/src/abstractcontactformatter.h 9f4fbf2 
  akonadi-contact/src/abstractcontactformatter.cpp bd13254 
  ktnef/src/CMakeLists.txt f16a6d3 
  ktnef/src/formatter.cpp e8b2d37 
  kcontacts/src/vcarddrag.h PRE-CREATION 
  kcontacts/src/vcarddrag.cpp PRE-CREATION 
  kcontacts/src/vcardparser/CMakeLists.txt PRE-CREATION 
  kcontacts/tests/CMakeLists.txt PRE-CREATION 
  kcontacts/tests/testwrite.cpp PRE-CREATION 
  kcontacts/autotests/keytest.cpp PRE-CREATION 
  kcontacts/autotests/phonenumbertest.cpp PRE-CREATION 
  kcontacts/autotests/secrecytest.cpp PRE-CREATION 
  kcontacts/src/CMakeLists.txt PRE-CREATION 
  kcontacts/src/Messages.sh PRE-CREATION 
  kcontacts/CMakeLists.txt PRE-CREATION 
  kcontacts/autotests/CMakeLists.txt PRE-CREATION 
  akonadi-contact/src/contacteditor.h 7075af9 
  akonadi-contact/src/contacteditor.cpp 5868a2a 
  akonadi-contact/src/contacteditordialog.cpp 8710cfa 
  akonadi-contact/src/contacteditorpageplugin.h b505ed3 
  akonadi-contact/src/contactcompletionmodel.cpp 11b9c17 
  akonadi-contact/src/contactdefaultactions.h efb4539 
  akonadi-contact/src/contactdefaultactions.cpp 8f04df1 
  akonadi-contact/src/actions/showaddressaction.h c69d476 
  akonadi-contact/src/actions/showaddressaction.cpp e2125b6 
  akonadi-contact/src/actions/smsdialog.h 00751fb 
  akonadi-contact/src/actions/smsdialog.cpp bfaa3f7 
  akonadi-contact/src/abstractcontactgroupformatter.h cf608b9 
  akonadi-contact/src/abstractcontactgroupformatter.cpp 3ffb3a4 
  akonadi-contact/src/actions/dialphonenumberaction.h 69a8f00 
  akonadi-contact/src/actions/dialphonenumberaction.cpp ee3b7e4 
  akonadi-contact/src/actions/sendsmsaction.h c41ad00 
  akonadi-contact/src/actions/sendsmsaction.cpp 722e7e8 

Diff: https://git.reviewboard.kde.org/r/120982/diff/


Testing
-------

Built KContacts, KPeople and KTp with it.
Tests still pass.

Will try the rest of the kdepimlibs after it's agreed that this change is desired.


Thanks,

Aleix Pol Gonzalez

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

More information about the kde-pim mailing list