[Kde-pim] Review Request 120982: Rename KABC to KContacts

[Laurent Montel]

> On nov. 5, 2014, 6:17 matin, Laurent Montel wrote:
> > kabc/CMakeLists.txt, line 35
> > <https://git.reviewboard.kde.org/r/120982/diff/2/?file=325666#file325666line35>
> >
> >     You forgot to rename generated file in Message.sh I think.

And you need to ask rename all kabc5.po to kcontacts5.po.

After that it seems ok for me.
But before to commit it we need to have patch for kdepim/kdepim-runtime.
Regards


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120982/#review69870
-----------------------------------------------------------


On nov. 4, 2014, 3:57 après-midi, Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120982/
> -----------------------------------------------------------
> 
> (Updated nov. 4, 2014, 3:57 après-midi)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> When looking into what needs to be done to get kabc released, I was suggested to rename it into something else. In this patch I'm suggesting to rename it to KContacts.
> 
> 
> Diffs
> -----
> 
>   kabc/tests/testwrite.cpp c9034f3 
>   kabc/src/plugin.h 1f9005e 
>   kabc/src/plugin.cpp d89c708 
>   kabc/src/secrecy.h 33108b1 
>   kabc/src/secrecy.cpp 968d3a5 
>   kabc/src/sortmode.h 36be9c8 
>   kabc/src/sortmode.cpp 7477ce4 
>   kabc/src/sound.h 2a7d205 
>   kabc/src/sound.cpp 5e399cb 
>   kabc/src/timezone.h 8311c5b 
>   kabc/src/timezone.cpp 9c7ae1d 
>   kabc/src/vcardconverter.h 4c19d0f 
>   kabc/src/vcardconverter.cpp b7adb94 
>   kabc/src/vcarddrag.h 11e0f4b 
>   kabc/src/vcarddrag.cpp 69a7f42 
>   kabc/src/vcardparser/CMakeLists.txt 7fb0c88 
>   kabc/src/vcardparser/vcard.h 5153cfa 
>   kabc/src/vcardparser/vcard.cpp e2600ec 
>   kabc/src/vcardparser/vcardline.h 8290d7f 
>   kabc/src/vcardparser/vcardline.cpp c495a33 
>   kabc/src/vcardparser/vcardparser.h 3497642 
>   kabc/src/vcardparser/vcardparser.cpp c2ae6d5 
>   kabc/src/vcardtool.h 25a95e5 
>   kabc/src/vcardtool.cpp 419c755 
>   kabc/tests/CMakeLists.txt bd31124 
>   kabc/tests/testread.cpp 288db76 
>   kabc/tests/testread2.cpp 6495642 
>   kabc/tests/testutils.h b8d5cc6 
>   kabc/tests/testutils.cpp f6f5821 
>   kabc/src/contactgrouptool.h 83c8a91 
>   kabc/src/contactgrouptool.cpp b45cefc 
>   kabc/src/errorhandler.h 6a421dc 
>   kabc/src/errorhandler.cpp 28aa360 
>   kabc/src/field.h f917868 
>   kabc/src/field.cpp 53a7345 
>   kabc/src/geo.h 5d67562 
>   kabc/src/geo.cpp 85adfbd 
>   kabc/src/kabc_debug.h 202fc8f 
>   kabc/src/key.h 8a1fbb9 
>   kabc/src/key.cpp e8df5b7 
>   kabc/src/ldifconverter.h d12bdbf 
>   kabc/src/ldifconverter.cpp 059b46d 
>   kabc/src/phonenumber.h cab5d6b 
>   kabc/src/phonenumber.cpp 84481dd 
>   kabc/src/picture.h 3e9780f 
>   kabc/src/picture.cpp 0ff7386 
>   kabc/autotests/testkabcdlg.cpp d1365f4 
>   kabc/autotests/testlock.h e49f1cd 
>   kabc/autotests/testlock.cpp 1f3bf9e 
>   kabc/autotests/testroundtrip.cpp b166d74 
>   kabc/autotests/timezonetest.h ce2d792 
>   kabc/autotests/timezonetest.cpp faaf3b2 
>   kabc/autotests/vcarddragtest.cpp dccf7b2 
>   kabc/src/CMakeLists.txt 9c74903 
>   kabc/src/address.h de079a6 
>   kabc/src/address.cpp 046850b 
>   kabc/src/addressee.h baa9e99 
>   kabc/src/addressee.cpp 4d2f788 
>   kabc/src/addresseehelper.h 84dad2a 
>   kabc/src/addresseehelper.cpp 933fc1b 
>   kabc/src/addresseelist.h 4ffe8db 
>   kabc/src/addresseelist.cpp 1a9a64d 
>   kabc/src/contactgroup.h 2a7a695 
>   kabc/src/contactgroup.cpp 3e36521 
>   kabc/autotests/phonenumbertest.cpp 44f4bc8 
>   kabc/autotests/picturetest.h 15e11df 
>   kabc/autotests/picturetest.cpp c4d4d36 
>   kabc/autotests/secrecytest.h dccdf57 
>   kabc/autotests/secrecytest.cpp 76c473a 
>   kabc/autotests/soundtest.h 97adbc6 
>   kabc/autotests/soundtest.cpp ea10b71 
>   kabc/autotests/testkabc.cpp 0f498b7 
>   kabc/autotests/addresstest.h 73bac83 
>   kabc/autotests/addresstest.cpp b6a8832 
>   kabc/autotests/bigread.cpp 442994d 
>   kabc/autotests/bigwrite.cpp 40c56fc 
>   kabc/autotests/contactgrouptest.cpp b40f65c 
>   kabc/autotests/geotest.h 08665d0 
>   kabc/autotests/geotest.cpp 610bf2d 
>   kabc/autotests/kabcargl.cpp db3db9e 
>   kabc/autotests/keytest.h adde49a 
>   kabc/autotests/keytest.cpp f29182d 
>   kabc/autotests/phonenumbertest.h ec4ba8d 
>   kabc/CMakeLists.txt 0da5c6f 
>   kabc/KF5AbcConfig.cmake.in d521848 
>   kabc/autotests/CMakeLists.txt 50968c9 
>   kabc/autotests/addresseetest.h 6d5f7f0 
>   kabc/autotests/addresseetest.cpp dd5cedb 
> 
> Diff: https://git.reviewboard.kde.org/r/120982/diff/
> 
> 
> Testing
> -------
> 
> Built KContacts, KPeople and KTp with it.
> Tests still pass.
> 
> Will try the rest of the kdepimlibs after it's agreed that this change is desired.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/