[Kde-pim] Review Request 120967: prevent failed ImapInterval interval overflow assertion
René J.V. Bertin
rjvbertin at gmail.com
Tue Nov 4 01:02:15 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120967/
-----------------------------------------------------------
Review request for KDEPIM.
Repository: kdepim-runtime
Description
-------
This seems to resolve the issue I reported a bit earlier tonight:
https://bugs.kde.org/show_bug.cgi?id=340614
The patch avoids the potential overflow by checking against the bounds before incrementing the interval's starting point (setBegin): see https://bugs.kde.org/show_bug.cgi?id=340614#c5
I really couldn't resist correcting the spelling of the interval variables (from interval*l*) but had I foreseen it'd make the diff so hard to read I'd have done it in a second step...
Diffs
-----
resources/imap/batchfetcher.h a666714
resources/imap/batchfetcher.cpp f6b1310
Diff: https://git.reviewboard.kde.org/r/120967/diff/
Testing
-------
On Kubuntu 14.04 with KDE 4.14.2 from the kubuntu-backports PPA; all kdepim packages built with clang-3.5
Thanks,
René J.V. Bertin
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list