[Kde-pim] Review Request 117993: Stop needlessly calling KDirWatch::stopScan().

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117993/#review57431
-----------------------------------------------------------


This review has been submitted with commit 8c64e00460a173141d69624cb36fca19801405b4 by Raphael Kubo da Costa to branch KDE/4.13.

- Commit Hook


On May 4, 2014, 10:57 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117993/
> -----------------------------------------------------------
> 
> (Updated May 4, 2014, 10:57 p.m.)
> 
> 
> Review request for KDEPIM, David Faure and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Not only should the call be unnecessary, but it also causes an infinite
> loop when KDirWatch is set to use QFileSystemWatcher: the
> KDirWatch::stopScan()/addDir()/startScan() combination makes the slot
> where they're called end up being infinitely triggered.
> 
> 
> Diffs
> -----
> 
>   grantleetheme/grantleethememanager.cpp 09e95f55f077d5cee94f2a63dfa5b1042e65091c 
>   pimcommon/templatewidgets/templatemanager.cpp a0678e8e537d55a824acb2a5911674340708a24c 
> 
> Diff: https://git.reviewboard.kde.org/r/117993/diff/
> 
> 
> Testing
> -------
> 
> KMail is usable with QFileSystemWatcher.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/