[Kde-pim] Review Request 117993: Stop needlessly calling KDirWatch::stopScan().
Raphael Kubo da Costa
rakuco at FreeBSD.org
Sun May 4 23:57:07 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117993/
-----------------------------------------------------------
Review request for KDEPIM, David Faure and Laurent Montel.
Repository: kdepim
Description
-------
Not only should the call be unnecessary, but it also causes an infinite
loop when KDirWatch is set to use QFileSystemWatcher: the
KDirWatch::stopScan()/addDir()/startScan() combination makes the slot
where they're called end up being infinitely triggered.
Diffs
-----
grantleetheme/grantleethememanager.cpp 09e95f55f077d5cee94f2a63dfa5b1042e65091c
pimcommon/templatewidgets/templatemanager.cpp a0678e8e537d55a824acb2a5911674340708a24c
Diff: https://git.reviewboard.kde.org/r/117993/diff/
Testing
-------
KMail is usable with QFileSystemWatcher.
Thanks,
Raphael Kubo da Costa
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list