[Kde-pim] Review Request 7110: Install only one translated autocorrect xm from l10n-kde4/[lang]/data

Burkhard Lück lueck at hube-lueck.de
Tue May 6 12:43:37 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7110/
-----------------------------------------------------------

Review request for KDE PIM and Localization and Translation (l10n).


Repository: kde


Description
-------

trunk/l10n-kde4/[lang]/data + branches/stable/[lang]/data both have two identical translated 
autocorrect xml files with different names in two different subdirs and different install path:

1) kdelibs/autocorrect/de_DE.xml with install( FILES  de_DE.xml DESTINATION ${DATA_INSTALL_DIR}/autocorrect )

and 

2) calligra/autocorrect/de.xml with install( FILES  de.xml DESTINATION ${DATA_INSTALL_DIR}/calligra/autocorrect )

As far as I understand the code in
calligra/plugins/textediting/autocorrection/Autocorrect.cpp
and
kdepim/pimcommon/autocorrection/autocorrection.cpp
calligra + kdepim would find the autocorrrect file de.xml installed to ${DATA_INSTALL_DIR}/autocorrect ),
therefore the duplicated autocorrect file should be removed


Diffs
-----

  trunk/l10n-kde4/de/data/calligra/autocorrect/CMakeLists.txt 1386314 
  trunk/l10n-kde4/de/data/calligra/autocorrect/de.xml 1386314 
  trunk/l10n-kde4/de/data/kdelibs/autocorrect/CMakeLists.txt 1386314 
  trunk/l10n-kde4/de/data/kdelibs/autocorrect/de_DE.xml 1386314 

Diff: https://svn.reviewboard.kde.org/r/7110/diff/


Testing
-------


Thanks,

Burkhard Lück

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list