[Kde-pim] Fwd: Re: Review Request 116841: do not double-encode vcard data and produce correct UTF-8

[Thomas Tanghus]

And then also to the mailing list. I think KMail has gotten a bit unstable in 
where replies go to. I normally just press 'r' in mailing lists which used to 
work. Apparently I have to get used to pressing 'l' instead.

----------  Forwarded Message  ----------

Subject: Re: [Kde-pim] Review Request 116841: do not double-encode vcard data 
and produce correct UTF-8
Date: Monday 17 March 2014, 00:38
From: Thomas Tanghus <thomas at tanghus.net>
To: Martin Koller <kollix at aon.at>
CC: Evert Pot <evertpot at gmail.com>

On Sunday 16 March 2014 22:52 you wrote:
> On Sunday 16 March 2014 20:41:44 Thomas Tanghus wrote:
> > On Sunday 16 March 2014 19:26 Martin Koller wrote:
> > > The DAV resource creates an addressee VCARD by using
> > > KABC::VCardConverter
> > > which already delivers UTF-8 when creating a V3.0 vcard. In an attempt
> > > to
> > > fix KDE bug https://bugs.kde.org/show_bug.cgi?id=310137 a wrong
> > > conversion
> > > from UTF-8 to finally again UTF-8 was introduced (6b829e2..762797c)
> > > This patch avoids the wrong conversion by just delivering directly the
> > > UTF-8 data.
> > > 
> > > With this patch applied, simple (short) names containing Umlauts can now
> > > correctly be created on the owncloud server.
> > > 
> > > However, I can still reproduce the original bug #310137, but analyzing
> > > this
> > > further, it seems that this is a bug in the owncloud WebDAV server,
> > > which
> > > obviously does not deal correctly with continuation lines. Importing
> > > such a
> > > 3.0 VCARD file via the web interface works in owncloud so it must be a
> > > bug
> > > in the WebDAV part of owncloud.
> > 
> > It seems to be an issue with the database collation we use[1], so
> > multibyte
> > chars corrupts the event/contact.
> > This goes for both the web UI and *DAV access though.
> > 
> > [1] https://github.com/owncloud/calendar/issues/198
> 
> This issue talks about mysql, but my owncloud installation does not use
> mysql but sqlite - which seems to be the default.

Yes, but bad default. Performance is much better using a real DBMS.

> And my test shows that it's definitely a difference when copying the contact
> via WebDAV or importing it via the web interface.
> (Note: I'm using a locally fixed version of the DAV resource with the patch
> I've already pushed now)
> 
> The test vcard file is attached here. Maybe you could verify this with a
> different client than the KDE WebDav one ?
> I'm struggling with this already the whole day ...
> Shall I open a bug report on owncloud.org ?

I can't import that card from ownCloud web UI either. The only way I could 
make it sort of render, was with setting encoding to utf-8 in kate, and it 
still says it contains invalid chars.
I suppose it's the triangle symbol (I can't paste it in KMail, but tried to 
attach a screenie). Anybody knows what character that is?

I've re-attached the vCard and CC'ed to Evert Pot who's behind the Sabre 
VObject library we use for parsing V* objects.
I do think that card is invalid, but I don't get any warnings when importing 
it.

-- 
Med venlig hilsen / Best Regards

Thomas Tanghus
-----------------------------------------
-- 
Med venlig hilsen / Best Regards

Thomas Tanghus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vcard_invalid_chars.png
Type: image/png
Size: 55271 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140317/b8262aef/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: encoding-bug.vcf
Type: text/vcard
Size: 852 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140317/b8262aef/attachment.vcf>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/