[Kde-pim] Review Request 116975: write "From " delimiter line in mbox with correct dateTime format

[Martin Koller]

> On March 22, 2014, 11:10 a.m., Kevin Krammer wrote:
> > kmbox/mbox_p.cpp, line 107
> > <https://git.reviewboard.kde.org/r/116975/diff/1/?file=256119#file256119line107>
> >
> >     why link the qmail doc and not the RFC 
> >     http://tools.ietf.org/html/rfc4155 itself?

just because this rfc is not normative, where the webpage ist just a reference after which I did the implementation
(When one looks up this commit later, it's faster to find where the format is described than reading much more text on the rfc)
... ok see below. It's not a good idea.
Fixed.


> On March 22, 2014, 11:10 a.m., Kevin Krammer wrote:
> > kmbox/mbox_p.cpp, line 111
> > <https://git.reviewboard.kde.org/r/116975/diff/1/?file=256119#file256119line111>
> >
> >     shouldn't that be currentDateTimeUtc() according to the RFC?

Ah yes ... so I really should have read the RFC up to the end and not only up to the linked web page, which says nothing about timezone ...
Fixed.


> On March 22, 2014, 11:10 a.m., Kevin Krammer wrote:
> > kmbox/mbox_p.cpp, line 113
> > <https://git.reviewboard.kde.org/r/116975/diff/1/?file=256119#file256119line113>
> >
> >     maybe also call toUtc()?

yes, of course ...


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116975/#review53736
-----------------------------------------------------------


On March 22, 2014, 10:52 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116975/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 10:52 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 297198
>     http://bugs.kde.org/show_bug.cgi?id=297198
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> The dateTime in the "From " delimiter line in an mbox file shall be formatted according to RFC4155, which was not the case.
> This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   kmbox/mbox_p.cpp 1e69267 
> 
> Diff: https://git.reviewboard.kde.org/r/116975/diff/
> 
> 
> Testing
> -------
> 
> copied mails into local mbox file (with and without a Date: header).
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/