[Kde-pim] Review Request 116975: write "From " delimiter line in mbox with correct dateTime format

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116975/#review53736
-----------------------------------------------------------



kmbox/mbox_p.cpp
<https://git.reviewboard.kde.org/r/116975/#comment37680>

    why link the qmail doc and not the RFC 
    http://tools.ietf.org/html/rfc4155 itself?



kmbox/mbox_p.cpp
<https://git.reviewboard.kde.org/r/116975/#comment37681>

    shouldn't that be currentDateTimeUtc() according to the RFC?



kmbox/mbox_p.cpp
<https://git.reviewboard.kde.org/r/116975/#comment37682>

    maybe also call toUtc()?


- Kevin Krammer


On March 22, 2014, 10:52 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116975/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 10:52 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 297198
>     http://bugs.kde.org/show_bug.cgi?id=297198
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> The dateTime in the "From " delimiter line in an mbox file shall be formatted according to RFC4155, which was not the case.
> This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   kmbox/mbox_p.cpp 1e69267 
> 
> Diff: https://git.reviewboard.kde.org/r/116975/diff/
> 
> 
> Testing
> -------
> 
> copied mails into local mbox file (with and without a Date: header).
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/