[Kde-pim] Project: Active Mail

[Kevin Krammer]

On Sunday, 2014-03-02, 00:35:26, Abhijeet Nikam wrote:
> Hi Dan!
> 
> Can multiple submissions be done through review-board? I tried finding
> the options but could not find it. Maybe I missed something.

Whoever commits them can merge them before pushing. So the review is not 
necessarily related to how it ends up in the repository.

> I there an another way to do it using git? I am still learning to use
> git so I don't know about it. I would be really happy if you could
> point me to some resources for learning to do that (multiple reviews
> in one commit to a branch/group of KDE).

Each review request is a single diff, but a diff can include changes over many 
files.

IMHO the only important thing is to make sure each review is "easy", i.e. 
doesn't take half an hour to go through all changes.

> I understand what you had to say since even my in-box would be full
> every time I would log in after getting up :)
> 
> That's why I have not submitted any further review requests. Or for
> now, should I continue with sending of 10 review requests per day on
> the review board?

That is almost a bit too much. Maybe 2 or three a day, if the previous ones 
have been completely reviewed.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140301/1fb631e5/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/