[Kde-pim] Review Request 116841: do not double-encode vcard data and produce correct UTF-8

[Martin Koller]

On Sunday 16 March 2014 20:41:44 Thomas Tanghus wrote:
> On Sunday 16 March 2014 19:26 Martin Koller wrote:
> > The DAV resource creates an addressee VCARD by using KABC::VCardConverter
> > which already delivers UTF-8 when creating a V3.0 vcard. In an attempt to
> > fix KDE bug https://bugs.kde.org/show_bug.cgi?id=310137 a wrong conversion
> > from UTF-8 to finally again UTF-8 was introduced (6b829e2..762797c)
> > This patch avoids the wrong conversion by just delivering directly the UTF-8
> > data.
> > 
> > With this patch applied, simple (short) names containing Umlauts can now
> > correctly be created on the owncloud server.
> > 
> > However, I can still reproduce the original bug #310137, but analyzing this
> > further, it seems that this is a bug in the owncloud WebDAV server, which
> > obviously does not deal correctly with continuation lines. Importing such a
> > 3.0 VCARD file via the web interface works in owncloud so it must be a bug
> > in the WebDAV part of owncloud.
>  
> It seems to be an issue with the database collation we use[1], so multibyte 
> chars corrupts the event/contact.
> This goes for both the web UI and *DAV access though.
> 
> [1] https://github.com/owncloud/calendar/issues/198

This issue talks about mysql, but my owncloud installation does not use mysql but
sqlite - which seems to be the default.
And my test shows that it's definitely a difference when copying the contact via WebDAV
or importing it via the web interface.
(Note: I'm using a locally fixed version of the DAV resource with the patch I've already
pushed now)

The test vcard file is attached here. Maybe you could verify this with a different client
than the KDE WebDav one ?
I'm struggling with this already the whole day ... 
Shall I open a bug report on owncloud.org ?

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\                        - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: encoding-bug.vcf
Type: text/vcard
Size: 865 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140316/14880f47/attachment.vcf>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/