[Kde-pim] Review Request 116877: Make ItemFetchJob work for in Item whose remote ID is specified

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116877/#review53351
-----------------------------------------------------------



akonadi/itemfetchjob.cpp
<https://git.reviewboard.kde.org/r/116877/#comment37539>

    I know this has not changed, but I wonder if this should not return here?


- Kevin Krammer


On March 18, 2014, 5:57 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116877/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 5:57 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Currently when an Item with only remote ID specified is supplied to the ItemFetchJob constructor, calling setCollection() to set its context does not (contrary to the apidox) work. In fact, setCollection() only works when fetching whole Collections, for which a separate constructor is provided. This patch makes setCollection(), and fetching by remote ID, work the way they are supposed to.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemfetchjob.cpp 4f8a59a 
> 
> Diff: https://git.reviewboard.kde.org/r/116877/diff/
> 
> 
> Testing
> -------
> 
> Tested with new KAlarm code.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/