[Kde-pim] Review Request 116877: Make ItemFetchJob work for in Item whose remote ID is specified

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116877/
-----------------------------------------------------------

(Updated March 19, 2014, 11:17 a.m.)


Review request for KDEPIM-Libraries.


Changes
-------

Revised patch which doesn't select a collection if one hasn't been specified.


Repository: kdepimlibs


Description
-------

Currently when an Item with only remote ID specified is supplied to the ItemFetchJob constructor, calling setCollection() to set its context does not (contrary to the apidox) work. In fact, setCollection() only works when fetching whole Collections, for which a separate constructor is provided. This patch makes setCollection(), and fetching by remote ID, work the way they are supposed to.


Diffs (updated)
-----

  akonadi/itemfetchjob.cpp 93168c3 

Diff: https://git.reviewboard.kde.org/r/116877/diff/


Testing
-------

Tested with new KAlarm code.


Thanks,

David Jarvie

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/