Review Request 118441: Manually sort the item list so that tagListHash.contains tests work

[Martin Steigerwald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118441/
-----------------------------------------------------------

(Updated June 7, 2014, 8:01 a.m.)


Review request for KDEPIM, KDEPIM-Libraries, Dan Vrátil, and Sergio Luis Martins.


Changes
-------

Moved before testcase that fails without sorting and added a TODO comment.


Bugs: 334218
    http://bugs.kde.org/show_bug.cgi?id=334218


Repository: kdepim-runtime


Description
-------

Manually sort the item list so that tagListHash.contains tests work

Otherwise the individual tests in this testcase may work on the wrong
mails as libmaildir doesn´t sort the entry list anymore.

This is related to the nosorting change from review request 117975.
                                                                                                                                                     
This needs to go into 4.13 branch as well before release of 4.13.2.

CCBUG: 334218


Diffs (updated)
-----

  resources/mixedmaildir/tests/itemfetchtest.cpp 28a0f6e301968efbed88f53e753fab91c8e083cf 

Diff: https://git.reviewboard.kde.org/r/118441/diff/


Testing
-------

Test passes:

martin at merkaba:~/KDE/Dev/kdepim-runtime/build/resources/mixedmaildir/tests> ./itemfetchtest
********* Start testing of ItemFetchTest *********
Config: Using QTest library 4.8.6, Qt 4.8.6
PASS   : ItemFetchTest::initTestCase()
PASS   : ItemFetchTest::testListingMaildir()
PASS   : ItemFetchTest::testListingMBox()
PASS   : ItemFetchTest::testSingleItemFetchMaildir()
QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241551.37547.kevin.krammer at demo.kolab.org" 
QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241552.01232.kevin.krammer at demo.kolab.org" 
QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241551.16855.kevin.krammer at demo.kolab.org" 
QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241550.46907.kevin.krammer at demo.kolab.org" 
PASS   : ItemFetchTest::testSingleItemFetchMBox()
PASS   : ItemFetchTest::cleanupTestCase()
Totals: 6 passed, 0 failed, 0 skipped
********* Finished testing of ItemFetchTest *********


Thanks,

Martin Steigerwald

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140607/4f06b0c7/attachment.html>