Review Request 118441: Manually sort the item list so that tagListHash.contains tests work

[Martin Steigerwald]

> On May 31, 2014, 6:53 p.m., Kevin Krammer wrote:
> > resources/mixedmaildir/tests/itemfetchtest.cpp, line 373
> > <https://git.reviewboard.kde.org/r/118441/diff/1/?file=276643#file276643line373>
> >
> >     looks ok, but I would prefer the sorting to happen right before here where it is needed.
> >     And a comment like this
> >     // TODO: check should not depend on any specific ordering

Thanks for feedback, Kevin. Please note, that I likely will not have much time for this one and similar review request #118400, which didn´t receive a review yet, as I am will hold a training in Berlin next week, with likely lot of appointments in the evenings. So in case I cannot come to it, I´d ask for having these two just go in for 4.13.2, and being allowed to improve later. Or someone else stepping in for this.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118441/#review58864
-----------------------------------------------------------


On May 31, 2014, 6:24 p.m., Martin Steigerwald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118441/
> -----------------------------------------------------------
> 
> (Updated May 31, 2014, 6:24 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries, Dan Vrátil, and Sergio Luis Martins.
> 
> 
> Bugs: 334218
>     http://bugs.kde.org/show_bug.cgi?id=334218
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Manually sort the item list so that tagListHash.contains tests work
> 
> Otherwise the individual tests in this testcase may work on the wrong
> mails as libmaildir doesn´t sort the entry list anymore.
> 
> This is related to the nosorting change from review request 117975.
>                                                                                                                                                      
> This needs to go into 4.13 branch as well before release of 4.13.2.
> 
> CCBUG: 334218
> 
> 
> Diffs
> -----
> 
>   resources/mixedmaildir/tests/itemfetchtest.cpp 28a0f6e301968efbed88f53e753fab91c8e083cf 
> 
> Diff: https://git.reviewboard.kde.org/r/118441/diff/
> 
> 
> Testing
> -------
> 
> Test passes:
> 
> martin at merkaba:~/KDE/Dev/kdepim-runtime/build/resources/mixedmaildir/tests> ./itemfetchtest
> ********* Start testing of ItemFetchTest *********
> Config: Using QTest library 4.8.6, Qt 4.8.6
> PASS   : ItemFetchTest::initTestCase()
> PASS   : ItemFetchTest::testListingMaildir()
> PASS   : ItemFetchTest::testListingMBox()
> PASS   : ItemFetchTest::testSingleItemFetchMaildir()
> QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241551.37547.kevin.krammer at demo.kolab.org" 
> QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241552.01232.kevin.krammer at demo.kolab.org" 
> QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241551.16855.kevin.krammer at demo.kolab.org" 
> QDEBUG : ItemFetchTest::testSingleItemFetchMBox() "201007241550.46907.kevin.krammer at demo.kolab.org" 
> PASS   : ItemFetchTest::testSingleItemFetchMBox()
> PASS   : ItemFetchTest::cleanupTestCase()
> Totals: 6 passed, 0 failed, 0 skipped
> ********* Finished testing of ItemFetchTest *********
> 
> 
> Thanks,
> 
> Martin Steigerwald
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140601/fd089bdb/attachment.html>