[Kde-pim] Review Request 118919: Outline for sending the message.

[Abhijeet Nikam]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118919/
-----------------------------------------------------------

(Updated June 25, 2014, 7:04 a.m.)


Review request for KDEPIM, Kevin Krammer and Michael Bohlender.


Changes
-------

Is this approach for sending the message fine?


Repository: kdepim


Description
-------

I have tried two approaches for sending part of mail. I still have to extend them. I feel approach 2 in send2.h and send2.cpp will be better. I still have to extend them. Will approach 2 work with the send function in messagesender.h? Re using the code as in approach 1 is getting a bit complicated. I will change the CMakeListst.txt ( Mobile) back again ( add definitions.. )  again after testing.


Diffs (updated)
-----

  mobile/CMakeLists.txt aca765d 
  mobile/api/mail/CMakeLists.txt 27ab592 
  mobile/api/mail/composer.h 2dfa16a 
  mobile/api/mail/composer.cpp 20333d1 
  mobile/api/mail/mailplugin.cpp bf1bf40 
  mobile/api/mail/receivermodel.h c2346ec 
  mobile/api/mail/receivermodel.cpp 26600a4 
  mobile/api/mail/recipient.h 5b7e317 
  mobile/api/mail/recipient.cpp 06e822b 
  mobile/api/mail/send2.h PRE-CREATION 
  mobile/api/mail/send2.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118919/diff/


Testing
-------


Thanks,

Abhijeet Nikam

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/