[Kde-pim] Review Request 118919: Outline for sending the message.

[Michael Bohlender]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118919/#review61034
-----------------------------------------------------------



mobile/api/mail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118919/#comment42503>

    is this really nessesary? 
    i would like to keep the cmake file as small as possible to make it easier to split it of the pim repo in the future.



mobile/api/mail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118919/#comment42504>

    same as above
    



mobile/api/mail/composer.cpp
<https://git.reviewboard.kde.org/r/118919/#comment42505>

    why?



mobile/api/mail/composer.cpp
<https://git.reviewboard.kde.org/r/118919/#comment42506>

    maybe leave the attachment part for now and put it in a seperate review



mobile/api/mail/main.qml
<https://git.reviewboard.kde.org/r/118919/#comment42508>

    abvously leave this out of the final commit



mobile/api/mail/main.qml
<https://git.reviewboard.kde.org/r/118919/#comment42507>

    make sure to put your name in the copyright for files that you want to commit ;)


- Michael Bohlender


On June 26, 2014, 1:23 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118919/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 1:23 p.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I have tried two approaches for sending part of mail. I still have to extend them. I feel approach 2 in send2.h and send2.cpp will be better. I still have to extend them. Will approach 2 work with the send function in messagesender.h? Re using the code as in approach 1 is getting a bit complicated. I will change the CMakeListst.txt ( Mobile) back again ( add definitions.. )  again after testing.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/CMakeLists.txt 27ab592 
>   mobile/api/mail/composer.h 2dfa16a 
>   mobile/api/mail/composer.cpp 20333d1 
>   mobile/api/mail/main.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118919/diff/
> 
> 
> Testing
> -------
> 
> When I click the screen , i get the following output on the console:
> plasmoidviewer(16808)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned 
> 
> And I don't receive a mail in my inbox or spam.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/