[Kde-pim] Will not package kdepim-runtime for 4.13.2 with failing tests - WAS- Re: kdepim-runtime: Broken tests in 4.13 branch

[Albert Astals Cid]

El Divendres, 6 de juny de 2014, a les 10:03:33, Christian Mollekopf va 
escriure:
> On Friday 06 June 2014 01.22:17 Albert Astals Cid wrote:
> > Keep me in CC, still not subscribed.
> > 
> > Honestly, I'm not convinced those tests failing are not a problem, and
> > even
> > if they were not, you only speak about 2 of the 3 failing tests, what
> > about
> > the other?
> 
> Sorry, I didn't realize that the imap-resource test was failing in 4.13 as
> well, it needed to be adapted to a change in kdepimlibs.
> 
> TestSuite.imap-testretrievecollectionmetadatatask
> 
> should be fixed now.

Nice, only two to nail down :)

Cheers,
  Albert

> 
> > Since the tests are still failing and noone has given me any good reason
> > for why we should not care if they fail I have decided not to package
> > kdepim- runtime for 4.13.2 tonight with the rest of repositories.
> > 
> > Since the release is on Tuesday, I'll give you guys a grace time until
> > Monday to fix the tests.
> 
> Thanks,
> Christian
> 
> > Cheers,
> > 
> >   Albert
> > 
> > El Dimecres, 4 de juny de 2014, a les 09:21:18, Martin Steigerwald va
> > 
> > escriure:
> > > Hi Albert,
> > > 
> > > Am Mittwoch, 4. Juni 2014, 00:56:20 schrieb Albert Astals Cid:
> > > > Can someone please fix
> > > > http://build.kde.org/view/KDE%20SC%20stable/job/kdepim-runtime_stable/
> > > > 73
> > > > 4/
> > > > te stReport/
> > > > 
> > > > Before the tagging of 4.13.2 on thursday or convince me that those
> > > > tests
> > > > don't need to pass?
> > > 
> > > mixedmaildir and maildir testcases have a tentative fix in
> > > 
> > > Review Request 118441: Manually sort the item list so that
> > > tagListHash.contains tests work
> > > 
> > > Review Request 118400: Manually sort the QStringList for the
> > > readEntryFlags
> > > test
> > > 
> > > These fixes work, but Kevin made some improvements requests.
> > > 
> > > I am holding a training this week and have stuff in the evenings as
> > > well,
> > > thus I can´t promise that I can take time to do these improvements
> > > before
> > > Thursday.
> > > 
> > > However: These tests just fail, cause libmaildir doesn´t list of
> > > filenames
> > > in a maildir directory anymore and the tests rely on that. I have the
> > > nosorting change running here with a large maildir for I think about 2
> > > weeks and observed no bad results. Thus I think it wouldn´t matter that
> > > much if those fixes are finished a bit after 4.13.2 tagging.
> > > 
> > > On the other hand I can just push these review requests as is and
> > > improve
> > > in a second iteration. Or someone else can step in and help.
> > > 
> > > Thanks,
> > 
> > _______________________________________________
> > KDE PIM mailing list kde-pim at kde.org
> > https://mail.kde.org/mailman/listinfo/kde-pim
> > KDE PIM home page at http://pim.kde.org/

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/