[Kde-pim] Will not package kdepim-runtime for 4.13.2 with failing tests - WAS- Re: kdepim-runtime: Broken tests in 4.13 branch

[Martin Steigerwald]

Hi!

Am Freitag, 6. Juni 2014, 01:22:17 schrieb Albert Astals Cid:
> Keep me in CC, still not subscribed.
> 
> Honestly, I'm not convinced those tests failing are not a problem, and even
> if they were not, you only speak about 2 of the 3 failing tests, what about
> the other?

The other one has nothing to do with the change I made. 

> Since the tests are still failing and noone has given me any good reason for
> why we should not care if they fail I have decided not to package kdepim-
> runtime for 4.13.2 tonight with the rest of repositories.

I did not say we should not care. But I still think that the maildir related 
testcase failures are an issue with the testcase expecting sorted filename 
entry list while KMail / KDEPIM does not expect this. So I do not to see the 
urgency of have them fixed *before* release of 4.13.2. However thats policy and 
I am willing to do what I can to meet it.

I´d offered to push my fixes as is and improve them later if time would be an 
issue, but no one has taken on that offer.

Anyway, according to

http://build.kde.org/view/KDE SC stable/job/kdepim_stable/1924/testReport/

the three tests are fixed?

Dan wrote: "Should be fixed now." in a reply to you. I did look at git repo, 
but only found fix for imap test case. But as the web page did not report any 
failure for these tests anymore I thought I may have missed the fix in git log.
 
> Since the release is on Tuesday, I'll give you guys a grace time until
> Monday to fix the tests.

I think will monday will work for me since its a public holiday in Germany.

Maybe I can do the fixes today afternoon or evening as well.

Ciao,
Martin

> Cheers,
>   Albert
> 
> El Dimecres, 4 de juny de 2014, a les 09:21:18, Martin Steigerwald va
> 
> escriure:
> > Hi Albert,
> > 
> > Am Mittwoch, 4. Juni 2014, 00:56:20 schrieb Albert Astals Cid:
> > > Can someone please fix
> > > http://build.kde.org/view/KDE%20SC%20stable/job/kdepim-runtime_stable/73
> > > 4/
> > > te stReport/
> > > 
> > > Before the tagging of 4.13.2 on thursday or convince me that those tests
> > > don't need to pass?
> > 
> > mixedmaildir and maildir testcases have a tentative fix in
> > 
> > Review Request 118441: Manually sort the item list so that
> > tagListHash.contains tests work
> > 
> > Review Request 118400: Manually sort the QStringList for the
> > readEntryFlags
> > test
> > 
> > These fixes work, but Kevin made some improvements requests.
> > 
> > I am holding a training this week and have stuff in the evenings as well,
> > thus I can´t promise that I can take time to do these improvements before
> > Thursday.
> > 
> > However: These tests just fail, cause libmaildir doesn´t list of filenames
> > in a maildir directory anymore and the tests rely on that. I have the
> > nosorting change running here with a large maildir for I think about 2
> > weeks and observed no bad results. Thus I think it wouldn´t matter that
> > much if those fixes are finished a bit after 4.13.2 tagging.
> > 
> > On the other hand I can just push these review requests as is and improve
> > in a second iteration. Or someone else can step in and help.
> > 
> > Thanks,

-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/