[Kde-pim] Will not package kdepim-runtime for 4.13.2 with failing tests

[Martin Steigerwald]

Hi Albert, hi Kevin, hi Daniel, hi KDEPIM devs,

Am Sonntag, 8. Juni 2014, 13:10:17 schrieb Albert Astals Cid:
> El Diumenge, 8 de juny de 2014, a les 11:00:05, Martin Steigerwald va
> 
> escriure:
> > Hi!
> > 
> > Am Freitag, 6. Juni 2014, 20:22:38 schrieb Albert Astals Cid:
> > > El Divendres, 6 de juny de 2014, a les 11:06:22, Martin Steigerwald va
> > 
> > […]
> > 
> > > > Am Freitag, 6. Juni 2014, 01:22:17 schrieb Albert Astals Cid:
> > > > > Keep me in CC, still not subscribed.
> > > > > 
> > > > > Honestly, I'm not convinced those tests failing are not a problem,
> > > > > and
> > > > > even
> > > > > if they were not, you only speak about 2 of the 3 failing tests,
> > > > > what
> > > > > about
> > > > > the other?
> > > > 
> > > > The other one has nothing to do with the change I made.
> > > 
> > > Christian fixed it :)
> > 
> > Good. I fixed the other too now in KDE/4.13 and master:
> > 
> > KDE/4.13:
> > 100% tests passed, 0 tests failed out of 41
> 
> Not what jenkins says
> 
> http://build.kde.org/view/KDE%20SC%20stable/job/kdepim-runtime_stable/

Just timing?

All I can answer to this is:

martin at merkaba:~/KDE/Dev/kdepim-runtime> LANG=C git checkout KDE/4.13
Switched to branch 'KDE/4.13'
Your branch is up-to-date with 'origin/KDE/4.13'.

martin at merkaba:~/KDE/Dev/kdepim-runtime> git log --pretty=oneline | head -2
6428954599ce87fd3844a43e3581aec47d4033ee
Manually sort the item list so that tagListHash.contains tests work
^ ^ ^ mixed maildir resource testcase

2b8c7db15c11c6d76a691b831fe83dc0879872ab
Manually sort the QStringList for the readEntryFlags test
^ ^ ^ maildir resource testcase

martin at merkaba:~/KDE/Dev/kdepim-runtime> git push 
Everything up-to-date


martin at merkaba:~/KDE/Dev/kdepim-runtime/build> make -j4 
[…]
martin at merkaba:~/KDE/Dev/kdepim-runtime/build> make test
Running tests...
Test project /home/martin/KDE/Dev/kdepim-runtime/build
[…]
      Start 16: maildir-testmaildir
16/41 Test #16: maildir-testmaildir .........................   Passed    0.06 
sec
[…]
      Start 30: mixedmaildir-itemfetchtest
30/41 Test #30: mixedmaildir-itemfetchtest ..................   Passed    2.06 
sec
[…]

100% tests passed, 0 tests failed out of 41

Total Test time (real) =  17.85 sec


If there is anything missing, please enlighten me as to what. As I do not
know what it is. Please consider that I am a newbie in all of this and do not 
magically know all possible pitfalls regarding testcases in KDEPIM.

The only idea I have still left is that moving down the sorting to the  
tagListHash.contains may unveilled that another tests fails *sometimes*, 
depending on the unsorted order of the entries, but that doesn´t match

FAIL!  : ItemFetchTest::testListingMaildir() '!tagListHash.contains( items[ 0 
].remoteId() )' returned FALSE. ()
   Loc: [/srv/jenkins/workspace/kdepim-
runtime_stable/resources/mixedmaildir/tests/itemfetchtest.cpp(376)]

from

http://build.kde.org/view/KDE SC stable/job/kdepim-
runtime_stable/lastCompletedBuild/testReport/(root)/TestSuite/mixedmaildir_itemfetchtest/

Thanks,
Martin


> 
> Cheers,
>   Albert
> 
> > master:
> > 
> > The following tests FAILED:
> >          12 - imap-testretrievecollectionmetadatatask (Failed)
> > > > > 
> > > > > Since the tests are still failing and noone has given me any good
> > > > > reason
> > > > > for why we should not care if they fail I have decided not to
> > > > > package
> > > > > kdepim- runtime for 4.13.2 tonight with the rest of repositories.
> > > > 
> > > > I did not say we should not care. But I still think that the maildir
> > > > related testcase failures are an issue with the testcase expecting
> > > > sorted
> > > > filename entry list while KMail / KDEPIM does not expect this. So I do
> > > > not to see the urgency of have them fixed *before* release of 4.13.2.
> > > > However thats policy and I am willing to do what I can to meet it.
> > > > 
> > > > I´d offered to push my fixes as is and improve them later if time
> > > > would
> > > > be
> > > > an issue, but no one has taken on that offer.
> > > > 
> > > > Anyway, according to
> > > > 
> > > > http://build.kde.org/view/KDE SC
> > > > stable/job/kdepim_stable/1924/testReport/
> > > > 
> > > > the three tests are fixed?
> > > 
> > > That's kdepim, not kdepim-runtime.
> > 
> > Missed that. I am new to contributing to KDE (except for some CRM114
> > configuration for KMail years ago and bug reports).
> > 
> > > http://build.kde.org/view/KDE%20SC%20stable/job/kdepim-runtime_stable/
> > 
> > Ciao,

-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/