[Kde-pim] Akonadi: updated coding style

[Daniel Vratil]

On Thursday 31 of July 2014 18:08:17 Kevin Ottens wrote:
> Hello,
> 
> On Thursday 31 July 2014 14:06:56 Daniel Vrátil wrote:
> > I just merged Guy's coding-style branch in Akonadi git to master, which
> > means that in Akonadi we now follow the new KDE PIM coding style [0], like
> > we already do in kdepimlibs/akonadi.
> > 
> > I want to say big thank you to Guy for his work - it's an incredible
> > amount
> > of code he had to go through and fix and thanks to him we now have a
> > reasonable coding style which is also consistent with most of the KDE
> > projects.
> 
> Note however that it introduced some behavior change. The patch is just
> insanely big so it'll be hard to spot *where* it is, but I got some of my
> tests depending on knut which started to fail after this update. See my
> struggle there:
> http://build.kde.org/job/zanshin_master/
> 
> I thought it was one of my own commits, but I finally nailed it down to that
> coding style commit. If I revert it locally my tests pass again.
> 
> I found a workaround for the time being (I'll CC you Dan on it), but that
> might require being investigated.

Yep, it looks like I screwed up something during rebase. It more or less 
points to a problem with collections (since some collection-related tests 
started failing in Jenkins), so that should make it a bit easier to nail down. 
I'll look into it tonight or tomorrow morning.

Dan

> 
> Regards.

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/