[Kde-pim] Review Request 114996: Close mailbox before renaming it

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114996/
-----------------------------------------------------------

Review request for KDEPIM and Christian Mollekopf.


Bugs: 324932
    http://bugs.kde.org/show_bug.cgi?id=324932


Repository: kdepim-runtime


Description
-------

This is a follow-up of review 112786 - some servers don't allow removing or renaming mailboxes when they are opened, so we CLOSE them first, before working with them.

If you are fine with it, I'd commit version without the emitWarning() string to 4.12, and with the warning string to master.


Diffs
-----

  resources/imap/movecollectiontask.h d762f4a 
  resources/imap/movecollectiontask.cpp 64f7a80 

Diff: https://git.reviewboard.kde.org/r/114996/diff/


Testing
-------

It's been confirmed in the bug report that this fixes removing of mailboxes from servers that have such restrictions, so I assume it will work for renaming too.


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/