[Kde-pim] Review Request 114996: Close mailbox before renaming it

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114996/#review47298
-----------------------------------------------------------

Ship it!


Looks good beside that remark, no need for another diff.


resources/imap/movecollectiontask.cpp
<https://git.reviewboard.kde.org/r/114996/#comment33689>

    I'd prefer a static_cast here since we know that the cast is valid and we the result of the cast is anyways not checked. Makes it a bit more explicit IMO.


- Christian Mollekopf


On Jan. 13, 2014, 9:46 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114996/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 9:46 a.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Bugs: 324932
>     http://bugs.kde.org/show_bug.cgi?id=324932
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This is a follow-up of review 112786 - some servers don't allow removing or renaming mailboxes when they are opened, so we CLOSE them first, before working with them.
> 
> If you are fine with it, I'd commit version without the emitWarning() string to 4.12, and with the warning string to master.
> 
> 
> Diffs
> -----
> 
>   resources/imap/movecollectiontask.h d762f4a 
>   resources/imap/movecollectiontask.cpp 64f7a80 
> 
> Diff: https://git.reviewboard.kde.org/r/114996/diff/
> 
> 
> Testing
> -------
> 
> It's been confirmed in the bug report that this fixes removing of mailboxes from servers that have such restrictions, so I assume it will work for renaming too.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/