[Kde-pim] Review Request 114996: Close mailbox before renaming it

[Jan Kundrát]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114996/#review47304
-----------------------------------------------------------


CLOSE performs a silent EXPUNGE behind the scenes. Are you sure this is what you really want to do?

The alternatives are either UNSELECT if the server supports that, or, for just-RFC-3501, "EXAMINE something-which-doesnt-exist".

- Jan Kundrát


On Jan. 13, 2014, 10:29 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114996/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 10:29 a.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Bugs: 324932
>     http://bugs.kde.org/show_bug.cgi?id=324932
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This is a follow-up of review 112786 - some servers don't allow removing or renaming mailboxes when they are opened, so we CLOSE them first, before working with them.
> 
> If you are fine with it, I'd commit version without the emitWarning() string to 4.12, and with the warning string to master.
> 
> 
> Diffs
> -----
> 
>   resources/imap/movecollectiontask.h d762f4a 
>   resources/imap/movecollectiontask.cpp 64f7a80 
> 
> Diff: https://git.reviewboard.kde.org/r/114996/diff/
> 
> 
> Testing
> -------
> 
> It's been confirmed in the bug report that this fixes removing of mailboxes from servers that have such restrictions, so I assume it will work for renaming too.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/