[Kde-pim] Review Request 114505: ItemFetchJob: Add setCollectItems

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114505/
-----------------------------------------------------------

(Updated Jan. 21, 2014, 5:01 p.m.)


Review request for KDEPIM.


Changes
-------

Sorry about the delay.

I've been testing this out today, and I still see very high memory usage while indexing. I'm running massif and analyzing whats happening.


Repository: kdepimlibs


Description
-------

    This allows us to control if the items being fetched are internally
    collected in order to be accessed later via the items() function.
    
    We want to disable this in the case of email indexing where every
    item in every collection is loaded into memory along with its entire
    payload. Collecting everything results in very high memory usage.


Diffs (updated)
-----

  akonadi/itemfetchjob.h f9c52a2 
  akonadi/itemfetchjob.cpp 93168c3 

Diff: https://git.reviewboard.kde.org/r/114505/diff/


Testing
-------


Thanks,

Vishesh Handa

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/