[Kde-pim] Review Request 114505: ItemFetchJob: Add setCollectItems

[Vishesh Handa]

> On Dec. 17, 2013, 6:12 p.m., Kevin Krammer wrote:
> > akonadi/itemfetchjob.cpp, line 226
> > <https://git.reviewboard.kde.org/r/114505/diff/3/?file=226461#file226461line226>
> >
> >     need to move out of the if

Removed the return. It was not really required.


> On Dec. 17, 2013, 6:12 p.m., Kevin Krammer wrote:
> > akonadi/itemfetchjob.cpp, line 228
> > <https://git.reviewboard.kde.org/r/114505/diff/3/?file=226461#file226461line228>
> >
> >     else if up to previous line

Why? This seems correct to me.


> On Dec. 17, 2013, 6:12 p.m., Kevin Krammer wrote:
> > akonadi/itemfetchjob.h, line 200
> > <https://git.reviewboard.kde.org/r/114505/diff/3/?file=226460#file226460line200>
> >
> >     Just some brainstorming for names:
> >     EmitSingleItem or EmitItemsIndividually
> >     he bulk one could then be
> >     EmitItemBatches or EmitItemsInBatches
> >

I like these names better. Updated to - EmitItemsIndividually and EmitItemsinBatches.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114505/#review45881
-----------------------------------------------------------


On Jan. 21, 2014, 5:01 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114505/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 5:01 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
>     This allows us to control if the items being fetched are internally
>     collected in order to be accessed later via the items() function.
>     
>     We want to disable this in the case of email indexing where every
>     item in every collection is loaded into memory along with its entire
>     payload. Collecting everything results in very high memory usage.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemfetchjob.h f9c52a2 
>   akonadi/itemfetchjob.cpp 93168c3 
> 
> Diff: https://git.reviewboard.kde.org/r/114505/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/