[Kde-pim] Review Request 108878: syndication: Make Atom entry's author list fall back to source's and feed's

[Bartosz Brachaczek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108878/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 12:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Frank Osterfeld.


Bugs: 314799
    http://bugs.kde.org/show_bug.cgi?id=314799


Repository: kdepimlibs


Description
-------

According to RFC 4287 [4.2.1]:

    If an atom:entry element does not contain atom:author elements, then
    the atom:author elements of the contained atom:source element are
    considered to apply.  In an Atom Feed Document, the atom:author
    elements of the containing atom:feed element are considered to apply
    to the entry if there are no atom:author elements in the locations
    described above.

This patch is what I believe is a correct fix implementing the above logic.


Diffs
-----

  syndication/atom/document.cpp da0838b 
  syndication/atom/entry.h 76d3cbe 
  syndication/atom/entry.cpp c8c9643 
  syndication/tests/atom/atom10_authors_priority.xml PRE-CREATION 
  syndication/tests/atom/atom10_authors_priority.xml.expected PRE-CREATION 
  syndication/tests/atom/heise-atom.xml.expected 888b8ab 

Diff: https://git.reviewboard.kde.org/r/108878/diff/


Testing
-------

I updated and successfully ran the test suite. I also tested Akregator with patched kdepimlibs and bug 314799 is gone.


Thanks,

Bartosz Brachaczek

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/