[Kde-pim] Review Request 108878: syndication: Make Atom entry's author list fall back to source's and feed's

[Christophe Giboudeaux]

> On Jan. 3, 2014, 12:35 p.m., Commit Hook wrote:
> > This review has been submitted with commit da4771582d438d54a96eacb55bb6219bfe520b4b by Christophe Giboudeaux on behalf of Bartosz Brachaczek to branch KDE/4.11.

Note: Your patch breaks one test:
The following tests FAILED:
         25 - Atom-/kde/src/4/pim/kdepimlibs/syndication/tests/atom/tbray.org_nested_xmlbase.xml (Failed)


- Christophe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/108878/#review46686
-----------------------------------------------------------


On Jan. 3, 2014, 12:35 p.m., Bartosz Brachaczek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/108878/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 12:35 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Frank Osterfeld.
> 
> 
> Bugs: 314799
>     http://bugs.kde.org/show_bug.cgi?id=314799
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> According to RFC 4287 [4.2.1]:
> 
>     If an atom:entry element does not contain atom:author elements, then
>     the atom:author elements of the contained atom:source element are
>     considered to apply.  In an Atom Feed Document, the atom:author
>     elements of the containing atom:feed element are considered to apply
>     to the entry if there are no atom:author elements in the locations
>     described above.
> 
> This patch is what I believe is a correct fix implementing the above logic.
> 
> 
> Diffs
> -----
> 
>   syndication/atom/document.cpp da0838b 
>   syndication/atom/entry.h 76d3cbe 
>   syndication/atom/entry.cpp c8c9643 
>   syndication/tests/atom/atom10_authors_priority.xml PRE-CREATION 
>   syndication/tests/atom/atom10_authors_priority.xml.expected PRE-CREATION 
>   syndication/tests/atom/heise-atom.xml.expected 888b8ab 
> 
> Diff: https://git.reviewboard.kde.org/r/108878/diff/
> 
> 
> Testing
> -------
> 
> I updated and successfully ran the test suite. I also tested Akregator with patched kdepimlibs and bug 314799 is gone.
> 
> 
> Thanks,
> 
> Bartosz Brachaczek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/