[Kde-pim] Review Request 114996: Close mailbox before renaming it

[Daniel Vrátil]

On Monday 13 of January 2014 12:36:23 Jan Kundrát wrote:
> [Looks like RB won't send out comments for an already-closed review,
> resending.]

(I got an email from RB)

> 
> CLOSE performs a silent EXPUNGE behind the scenes. Are you sure this is
> what you really want to do?

The resource already calls EXPUNGE whenever it syncs a collection, so calling 
it once more when it renames the collections should do no harm (or am I 
missing something?)

> The alternatives are either UNSELECT if the server supports that, or, for
> just-RFC-3501, "EXAMINE something-which-doesnt-exist" -- see
> http://quickgit.kde.org/?p=trojita.git&a=blob&f=src/Imap/Tasks/UnSelectTask.
> cpp for how it's done within Trojita.

I didn't want to bother with handling fallback for servers without UNSELECT, 
so I used CLOSE. Switching to EXAMINE is a good idea (but CLOSE feels cleaner 
than opening a  non-existent folder). Christian, I can modify the 
{Move,Remove}CollectionTask to use EXAMINE if you want me to.

Thanks for you help Jan.

Dan

> 
> Cheers,
> Jan

-- 
Daniel Vrátil
KDE Desktop Team
Associate Software Engineer, Red Hat, Inc.

GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140113/4fd9c63f/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/