[Kde-pim] Review Request 113253: kimap: add methods to set/get the internal date for an APPEND query
Dan Vrátil
dvratil at redhat.com
Tue Feb 25 14:57:10 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113253/#review50827
-----------------------------------------------------------
Looks good, please update AppendJob unittest too.
- Dan Vrátil
On Feb. 25, 2014, 2:59 p.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113253/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 2:59 p.m.)
>
>
> Review request for KDEPIM and KDEPIM-Libraries.
>
>
> Bugs: 230635
> http://bugs.kde.org/show_bug.cgi?id=230635
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> This patch adds the methods AppendJob::setInternalDate() and AppendJob::internalDate().
> Those can be used to set the internal date for the APPEND command, see http://tools.ietf.org/html/rfc3501#section-6.3.11 .
>
> If setInternalDate() is not called, the exact same query is generated as before, so existing users of AppendJob should not break.
>
> This is needed to fix bug#230635, see https://git.reviewboard.kde.org/r/113254/
>
>
> Diffs
> -----
>
> kimap/appendjob.h d01f4f2
> kimap/appendjob.cpp 5035214
>
> Diff: https://git.reviewboard.kde.org/r/113253/diff/
>
>
> Testing
> -------
>
> Copy a mail to an IMAP server (using KMail).
>
> With the current (unpatched) kdepim-runtime, the APPEND still succeeds and the current date/time is used as internal date, i.e. there's no change in behaviour despite the patch.
>
> With a kdepim-runtime that includes the patch from Review Request #113254 , the APPEND succeeds as well, the date/time as specified in the mail header is set.
>
> I also ran akonadi with the KIMAP_LOGFILE environment variable set, and checked the resulting APPEND query string. In the first case it's exactly like before, in the second case a date/time string is added to the query respecting the RFC.
>
> I'm using this (in combination with https://git.reviewboard.kde.org/r/113254/) since October without issues, everything's working as expected.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list