[Kde-pim] Review Request 113253: kimap: add methods to set/get the internal date for an APPEND query

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113253/
-----------------------------------------------------------

(Updated Feb. 25, 2014, 2:59 p.m.)


Review request for KDEPIM and KDEPIM-Libraries.


Changes
-------

- explicitely convert the format string to QString in the call to internalDate.toString(), compilation fails with KDE 4.12 otherwise:
In file included from /usr/include/QtCore/qdatetime.h:45:0,
                 from /usr/include/QtCore/QDateTime:1,
                 from /usr/include/ktimezone.h:36,
                 from /usr/include/kdatetime.h:30,
                 from /home/abuild/rpmbuild/BUILD/kdepimlibs-4.12.2/kimap/appendjob.h:23,
                 from /home/abuild/rpmbuild/BUILD/kdepimlibs-4.12.2/kimap/appendjob.cpp:20:
/usr/include/QtCore/qstring.h: In member function 'virtual void KIMAP::AppendJob::doStart()':
/usr/include/QtCore/qstring.h:597:5: error: 'QString::QString(const char*)' is private
/home/abuild/rpmbuild/BUILD/kdepimlibs-4.12.2/kimap/appendjob.cpp:126:77: error: within this context

- changed the @since comments to 4.13


Bugs: 230635
    http://bugs.kde.org/show_bug.cgi?id=230635


Repository: kdepimlibs


Description
-------

This patch adds the methods AppendJob::setInternalDate() and AppendJob::internalDate().
Those can be used to set the internal date for the APPEND command, see http://tools.ietf.org/html/rfc3501#section-6.3.11 .

If setInternalDate() is not called, the exact same query is generated as before, so existing users of AppendJob should not break.

This is needed to fix bug#230635, see https://git.reviewboard.kde.org/r/113254/


Diffs (updated)
-----

  kimap/appendjob.h d01f4f2 
  kimap/appendjob.cpp 5035214 

Diff: https://git.reviewboard.kde.org/r/113253/diff/


Testing (updated)
-------

Copy a mail to an IMAP server (using KMail).

With the current (unpatched) kdepim-runtime, the APPEND still succeeds and the current date/time is used as internal date, i.e. there's no change in behaviour despite the patch.

With a kdepim-runtime that includes the patch from Review Request #113254 , the APPEND succeeds as well, the date/time as specified in the mail header is set.

I also ran akonadi with the KIMAP_LOGFILE environment variable set, and checked the resulting APPEND query string. In the first case it's exactly like before, in the second case a date/time string is added to the query respecting the RFC.

I'm using this (in combination with https://git.reviewboard.kde.org/r/113254/) since October without issues, everything's working as expected.


Thanks,

Wolfgang Bauer

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/