[Kde-pim] Coding style reviews

[Daniel Vrátil]

--===============1330640750354580715==
Content-Type: multipart/signed; boundary="nextPart17664555.ippr05ER7S"; micalg="pgp-sha1"; protocol="application/pgp-signature"


--nextPart17664555.ippr05ER7S
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Thursday 27 of February 2014 19:42:40 Kevin Krammer wrote:
> On Thursday, 2014-02-27, 18:49:14, Martin Klapetek wrote:
> > Hey,
> >=20
> > is it really necessary to post the coding style reviews one file pe=
r one
> > review? The amount of emails generated from it is...huge. 250 email=
s in
> > the
> > last 10 minutes. It makes also searching in the archives really har=
d*.
> > Also
> > it drowns anything else sent to the list plus makes people tune off=
 this
> > mailing list.
> >=20
> > Also I imagine opening 250 reviews must be quite annoying.

I guess Guy has some nifty scripts for that :)

>=20
> I am not sure what happend here, usually it is only around 10 reviews=
.
> Since Dan is the recipient this time instead of me my guess is that h=
e
> wanted all of them in one go?

I asked Guy not to do the coding styles for /akonadi folder before we a=
re done=20
with Christian, so it probably accumulated :-)

I'm wondering whether the commit hooks will deal with 300 "REVIEW" keyw=
ords :D

> > Can we please please tune it down to let's say 10 files per one rev=
iew? 20
> > maybe? Or maybe not sent it to this list at all?

Guy, could you please submit multiple files per review next time, so th=
at  we=20
don't spam others with emails from reviewboard? :-)

>=20
> If you are volunteering to do the reviews :)
> Because that is way to much for me to review in one go.

Seeing the amount, I'll help tomorrow :D

Dan

>=20
> Cheers,
> Kevin

=2D-=20
Daniel Vr=E1til | dvratil at redhat.com | dvratil on #kde-devel, #kontact,=
 #akonadi
KDE Desktop Team
Associate Software Engineer, Red Hat, Inc.

GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
--nextPart17664555.ippr05ER7S
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAABAgAGBQJTD7JEAAoJEMWdYU9vSuNI+O0IAN2gejtTI7gsMbBnXLQZtfwo
lLHBKYIt8qjzlvg8PIE1eQ+dR2brrF/KAerVcPsQvE60qLQrs7N9jXkT0/7oyKBg
iMRVrKhMx3DfYpaoroy7DLFggRTt+kSFjCXLPieQ20EC/ogDH4xNBkSH4ByiZlsK
DdcJioIHUcePpk7OMkgUPAbr+bcZd5zsgLjmv2kaU52iARpdZ0ajuaws0qzwjk2P
Dv/16Hq+BUvkICFVBG9em64J7bQmbZVLc2zZVX1QtVyIOh33kGMa8xIgoeAzw7Xw
kIi9muz2ElLzhi4W3MXzyiAJeo7FjOSk/6gp7ylExY0B593WX4V2qf+1wNfPhdo=
=z8q7
-----END PGP SIGNATURE-----

--nextPart17664555.ippr05ER7S--


--===============1330640750354580715==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============1330640750354580715==--