[Kde-pim] Review Request 121580: Small API review for KContacts

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121580/
-----------------------------------------------------------

(Updated Dec. 17, 2014, 4:41 p.m.)


Review request for KDEPIM.


Changes
-------

Addressed some of Milian's concerns.


Repository: kcontacts


Description
-------

- fixes a couple of remaining rename issues (kabc->kcontacts)
- QList->QVector from public API. It's been discussed many times, it doesnt' make much sense to use QList there.
- Moved AddresseeHelper attributes into a d-pointer.
- Kill ErrorHandler, it didn't have any users anyway.
- Added Geo::clear() method, for consistency.


Diffs (updated)
-----

  src/geo.cpp 92f62af 
  src/key.h 5203422 
  src/ldifconverter.h abc987d 
  src/ldifconverter.cpp 90e8d49 
  src/phonenumber.h a8d96da 
  src/vcardtool.h 292df6d 
  src/addresseelist.cpp 6acf9ae 
  src/errorhandler.h d09e097 
  src/errorhandler.cpp 9475619 
  src/geo.h 93b4e87 
  src/addressee.cpp fca731e 
  src/addresseehelper.h 7c85462 
  src/addresseehelper.cpp e1d0974 
  src/addresseelist.h 1114c6a 
  autotests/addresstest.cpp fd36f23 
  src/CMakeLists.txt 4772805 
  src/address.h 69b263d 
  src/address.cpp a6e1e84 
  src/addressee.h cef3bac 

Diff: https://git.reviewboard.kde.org/r/121580/diff/


Testing
-------

Tests pass, I still can use KTp+KPeople without crashes.


Thanks,

Aleix Pol Gonzalez

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/