[Kde-pim] Review Request 121310: Optimize queries: Do not retrieve known key used in the condition.

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121310/#review71180
-----------------------------------------------------------


I'm willing to bet that DBs can optimize these cases internally, so the only benefit would really be less data transmitted between DB and application.

But won't the fact, that each column has to be stored in a new variable cause the code to actually be slower than transmitting few more bytes to and from DB? The patch itself is OK, but I'm just wondering if there's actually any gain?

- Daniel Vrátil


On Dec. 1, 2014, 2:21 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121310/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 2:21 p.m.)
> 
> 
> Review request for Akonadi, Daniel Vrátil and Volker Krause.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> There is no point in doing a select like:
> 
> SELECT foo, bar FROM table WHERE foo = needle;
> 
> That can be rewritten to say
> 
> SELECT bar FROM table WHERE foo = needle;
> 
> This reduces the data traffic with the mysql server.
> 
> 
> Diffs
> -----
> 
>   server/src/storage/entities.xsl 94712933564a8f6c1bf99502e4af837f5934d41e 
> 
> Diff: https://git.reviewboard.kde.org/r/121310/diff/
> 
> 
> Testing
> -------
> 
> it works!
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/