[Kde-pim] Review Request 121310: Optimize queries: Do not retrieve known key used in the condition.

Daniel Vrátil dvratil at redhat.com
Tue Dec 2 15:20:36 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121310/#review71256
-----------------------------------------------------------

Ship it!


Ok, didn't know QtSql is *that* crappy :-) Thanks for the patch!

- Daniel Vrátil


On Dec. 1, 2014, 2:21 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121310/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 2:21 p.m.)
> 
> 
> Review request for Akonadi, Daniel Vrátil and Volker Krause.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> There is no point in doing a select like:
> 
> SELECT foo, bar FROM table WHERE foo = needle;
> 
> That can be rewritten to say
> 
> SELECT bar FROM table WHERE foo = needle;
> 
> This reduces the data traffic with the mysql server.
> 
> 
> Diffs
> -----
> 
>   server/src/storage/entities.xsl 94712933564a8f6c1bf99502e4af837f5934d41e 
> 
> Diff: https://git.reviewboard.kde.org/r/121310/diff/
> 
> 
> Testing
> -------
> 
> it works!
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list