[Kde-pim] Review Request 116987: fix mbox: make "check mail"/"update folder" without filewatch really do something

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116987/#review54740
-----------------------------------------------------------


Should the call perhaps go into retrieveCollections? Otherwise you'll reload the fill multiple times per sync, don't you? An I guess it should only reload the file that way if the filewatch is not enabled.

- Christian Mollekopf


On March 23, 2014, 10:06 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116987/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 10:06 a.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> When you have an mbox resource WITHOUT file watching, a "check mail" or "update folder" does NOTHING as MboxResource::retrieveItems() does not call reloadFile().
> This patch does that.
> 
> 
> Diffs
> -----
> 
>   resources/mbox/mboxresource.cpp 36aef8b 
> 
> Diff: https://git.reviewboard.kde.org/r/116987/diff/
> 
> 
> Testing
> -------
> 
> local mbox file without filewatch
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/