[Kde-pim] Review Request 116987: fix mbox: make "check mail"/"update folder" without filewatch really do something

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116987/#review55628
-----------------------------------------------------------

Ship it!


That looks ok. reloadFile() seems to take care of not loading the file again if there was no hash change so this should not impact unchanged mbox files that much.

I checked the ical and vcard resources and interestingly the former does reload in retrieveItems while the latter does not.
My guess is that the ical resource was fixed at some point, being used as the default for calendar data. The commit logs might contain useful information in case something else was additionally done to handle this correctly


- Kevin Krammer


On March 23, 2014, 10:06 a.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116987/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 10:06 a.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> When you have an mbox resource WITHOUT file watching, a "check mail" or "update folder" does NOTHING as MboxResource::retrieveItems() does not call reloadFile().
> This patch does that.
> 
> 
> Diffs
> -----
> 
>   resources/mbox/mboxresource.cpp 36aef8b 
> 
> Diff: https://git.reviewboard.kde.org/r/116987/diff/
> 
> 
> Testing
> -------
> 
> local mbox file without filewatch
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/