[Kde-pim] ContactSearchJob hangs for a minute

[Daniel Vrátil]

On Sunday 06 of April 2014 12:13:01 Christian Mollekopf wrote:
> On Saturday 05 April 2014 23.24:54 David Faure wrote:
> > On Tuesday 01 April 2014 06:46:55 Christian Mollekopf wrote:
> > > I'll look into this this evening, but you can already work around this
> > > by
> > > disabling remote search if you want.
> > 
> > Any news?
> 
> Nope, I looked at the code, couldn't find the problem and can't reproduce it
> myself.
> 
> > Indeed this made it possible for me to send emails again without waiting a
> > full minute between each email:
> > 
> > --- a/akonadi/itemsearchjob.cpp
> > +++ b/akonadi/itemsearchjob.cpp
> > @@ -34,7 +34,7 @@ class Akonadi::ItemSearchJobPrivate : public JobPrivate
> > 
> >  {
> >  
> >    public:
> >      ItemSearchJobPrivate( ItemSearchJob *parent, const SearchQuery &query
> >      )
> > 
> > -      : JobPrivate( parent ), mQuery( query ), mRecursive( false ),
> > mRemote( true ), mEmitTimer( 0 ) +      : JobPrivate( parent ), mQuery(
> > query ), mRecursive( false ), mRemote( false /*HACK*/ ), mEmitTimer( 0 ) {
> > 
> >      }
> > 
> > But I assume this isn't the correct fix?
> 
> It's not a fix, no. However, I think we should ship this default value since
> remote search is not currently useful since no resource implements it,
> except for the imap resource for which I already disabled remote search in
> the only relevant place (kmail search). So unless Daniel comes up with a
> better solution or a good reason why we shouldn't disable remote search I'm
> going to change the default value.

Ok, I give in :-D Please go ahead and disable remote by default in 
ItemSearchJob and SearchCreateJob. :)

Dan

> 
> Cheers,
> Christian

-- 
Daniel Vrátil | dvratil at redhat.com | dvratil on #kde-devel, #kontact, #akonadi
KDE Desktop Team
Associate Software Engineer, Red Hat, Inc.

GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140406/e2387359/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/