[Kde-pim] Review Request 117193: Fix 322708 - Allow encrypting mails with keys of unknown trust

[Sandro Knauß]

> On March 31, 2014, 6:39 a.m., Laurent Montel wrote:
> > We need a unittest for it

well, yes units tests are everytime a good idea. But the whole keyresolver is untested, so it is a bunch of work to implement unittests for this issue.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117193/#review54651
-----------------------------------------------------------


On March 30, 2014, 6:41 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117193/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 6:41 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 322708
>     http://bugs.kde.org/show_bug.cgi?id=322708
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Fix 322708 - Allow encrypting mails with keys of unknown trust
> 
> For encrypting an email, it is not nessacary to trust the key you use
> for encryption.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer/keyresolver.cpp a9fcecdcda707a003be5f136ca6987b2b3e98282 
> 
> Diff: https://git.reviewboard.kde.org/r/117193/diff/
> 
> 
> Testing
> -------
> 
> make test and create a mail with a key untrusted.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/