[Kde-pim] Review Request 117683: CollectionSync/Attribute: use new keepLocalChanges

Christian Mollekopf chrigi_1 at fastmail.fm
Tue Apr 22 15:43:15 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117683/
-----------------------------------------------------------

(Updated April 22, 2014, 2:43 p.m.)


Review request for KDEPIM-Libraries.


Changes
-------

Use the d-pointer hack.


Repository: kdepimlibs


Description
-------

CollectionSync/Attribute: use new keepLocalChanges

This new property allows resources to indicate whether the CollectionSync
should overwrite the locally stored changes.
This ensures that the CollectionSync doesn't overwrite existing attributes
with the default values provided by the resource on every sync.


Diffs (updated)
-----

  akonadi/attribute.h c57d2fb212f3ca8bd8031d09b42b9a5627806e52 
  akonadi/attribute.cpp c8291705a1c5f6a2654c516c1b9c9118d51b5f37 
  akonadi/collectionquotaattribute.cpp c8afebd1f0d4fd21cde0f62b37afbac962750272 
  akonadi/collectionrightsattribute.cpp 21b3646450993fd06aa378aae38016c0de0fb973 
  akonadi/collectionsync.cpp 73e1ccf4355a509dbff58a8af3727e5856778f33 
  akonadi/entitydisplayattribute.cpp 15d87006598c7f702640805f1202ba7c354e01bd 
  akonadi/tests/collectionsynctest.cpp c36d9396c5b7cd3f54b3c8e2c27a3cdd32c95789 

Diff: https://git.reviewboard.kde.org/r/117683/diff/


Testing
-------

Unittests.


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list