[Kde-pim] Review Request 117683: CollectionSync/Attribute: use new keepLocalChanges

[Christian Mollekopf]

> On April 22, 2014, 10:08 a.m., Dan Vrátil wrote:
> > akonadi/attribute.h, line 185
> > <https://git.reviewboard.kde.org/r/117683/diff/1/?file=267570#file267570line185>
> >
> >     According to http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#The_Do.27s_and_Don.27ts this is not BC:
> >     
> >     You can't .... add new virtual functions to non-leaf classes as this will break subclasses
> >     
> >

Fucking hell! you're right. Since we just ran out of options otherwise, that's the only one left I think: http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#Adding_new_data_members_to_classes_without_d-pointer


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117683/#review56175
-----------------------------------------------------------


On April 21, 2014, 11:20 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117683/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 11:20 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> CollectionSync/Attribute: use new keepLocalChanges
> 
> This new property allows resources to indicate whether the CollectionSync
> should overwrite the locally stored changes.
> This ensures that the CollectionSync doesn't overwrite existing attributes
> with the default values provided by the resource on every sync.
> 
> 
> Diffs
> -----
> 
>   akonadi/attribute.h c57d2fb212f3ca8bd8031d09b42b9a5627806e52 
>   akonadi/attribute.cpp c8291705a1c5f6a2654c516c1b9c9118d51b5f37 
>   akonadi/collectionquotaattribute.h edd29436e2bf28fab1ee8e0eadd84f7f7f0e8568 
>   akonadi/collectionquotaattribute.cpp c8afebd1f0d4fd21cde0f62b37afbac962750272 
>   akonadi/collectionrightsattribute.cpp 21b3646450993fd06aa378aae38016c0de0fb973 
>   akonadi/collectionrightsattribute_p.h dd7c40ccc49de8c01805fde2ad27481b4966d303 
>   akonadi/collectionsync.cpp 73e1ccf4355a509dbff58a8af3727e5856778f33 
>   akonadi/entitydisplayattribute.h e24dc2654e82995ccc35044a3fa3305cc1990c8c 
>   akonadi/entitydisplayattribute.cpp 15d87006598c7f702640805f1202ba7c354e01bd 
>   akonadi/tests/collectionsynctest.cpp c36d9396c5b7cd3f54b3c8e2c27a3cdd32c95789 
> 
> Diff: https://git.reviewboard.kde.org/r/117683/diff/
> 
> 
> Testing
> -------
> 
> Unittests.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/