[Kde-pim] Review Request 117097: Fix: when handling quoted-printable soft-broken lines, \r\n handling was missing

[Jan Kundrát]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117097/#review54777
-----------------------------------------------------------



kabc/vcardparser/testroundtrip.qrc
<https://git.reviewboard.kde.org/r/117097/#comment38261>

    This review request doesn't contain these newly added .vcf files.



kabc/vcardparser/vcardparser.cpp
<https://git.reviewboard.kde.org/r/117097/#comment38260>

    Instead of (*it).foo , you can typically use it->foo .


- Jan Kundrát


On March 26, 2014, 7:16 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117097/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 7:16 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 332340
>     http://bugs.kde.org/show_bug.cgi?id=332340
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> When a vcard has quoted-printable encoded lines with a soft line-break, the fetch for the next line did not handle the \r\n line handling
> as is done in the outer loop
> 
> 
> Diffs
> -----
> 
>   kabc/vcardparser/testroundtrip.qrc c4e2b7f 
>   kabc/vcardparser/vcardparser.cpp a432d1b 
> 
> Diff: https://git.reviewboard.kde.org/r/117097/diff/
> 
> 
> Testing
> -------
> 
> added a new vcard testcase
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/