[Kde-pim] Review Request 117097: Fix: when handling quoted-printable soft-broken lines, \r\n handling was missing

Martin Koller kollix at aon.at
Tue Apr 8 10:18:31 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117097/
-----------------------------------------------------------

(Updated April 8, 2014, 9:18 a.m.)


Review request for KDEPIM-Libraries and Kevin Krammer.


Changes
-------

Please either tell me what else to change or mark it as "ship it".
Thanks.


Bugs: 332340
    http://bugs.kde.org/show_bug.cgi?id=332340


Repository: kdepimlibs


Description
-------

When a vcard has quoted-printable encoded lines with a soft line-break, the fetch for the next line did not handle the \r\n line handling
as is done in the outer loop


Diffs
-----

  kabc/vcardparser/testroundtrip.qrc c4e2b7f 
  kabc/vcardparser/vcardparser.cpp a432d1b 

Diff: https://git.reviewboard.kde.org/r/117097/diff/


Testing
-------

added a new vcard testcase


File Attachments
----------------

vcard10.vcf
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/01/1c76af79-0519-4591-b242-2b18bea8cf94__vcard10.vcf
vcard10.vcf.ref
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/01/415d177b-2935-4243-bd73-9bf688ffb7bc__vcard10.vcf.ref


Thanks,

Martin Koller

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list