[Kde-pim] Review Request 112975: Set conforming string for postgreSQL

[Cédric Villemain]

> On Sept. 29, 2013, 1:15 p.m., Dan Vrátil wrote:
> >

I didn't consider what's happening when akonadi is managing postgresql server.


> On Sept. 29, 2013, 1:15 p.m., Dan Vrátil wrote:
> > server/src/storage/dbconfigpostgresql.cpp, line 175
> > <http://git.reviewboard.kde.org/r/112975/diff/3/?file=192961#file192961line175>
> >
> >     Could this be done the same (or other) way as s_c_s so that we could kill everything from l. 167 to l. 188?

listen_adress is a GUC that needs to be set before postgresql start. So it is not possible.
*but* akonadi can connect via socket instead of TCP ... 


> On Sept. 29, 2013, 1:15 p.m., Dan Vrátil wrote:
> > server/src/storage/dbconfigpostgresql.cpp, line 183
> > <http://git.reviewboard.kde.org/r/112975/diff/3/?file=192961#file192961line183>
> >
> >     I believe this can now go away?

might be. I'll see.


- Cédric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112975/#review40989
-----------------------------------------------------------


On Sept. 28, 2013, 2:40 p.m., Cédric  Villemain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112975/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2013, 2:40 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> So the input/output are as expected.
> 
> 
> Diffs
> -----
> 
>   server/src/storage/dbconfigpostgresql.cpp acc65af149d0d4849dca535e9d0599e234befab2 
> 
> Diff: http://git.reviewboard.kde.org/r/112975/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cédric  Villemain
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/