[Kde-pim] Review Request 112975: Set conforming string for postgreSQL

[Cédric Villemain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112975/#review41000
-----------------------------------------------------------



server/src/storage/dbconfigpostgresql.cpp
<http://git.reviewboard.kde.org/r/112975/#comment30101>

    locale should be based on the current sytem setting.
    
    --text-search-config=CFG might be set accordingly if akonadi expect to benefit from PostgreSQL full text (text vector, stemmers, ispell, ...)



server/src/storage/dbconfigpostgresql.cpp
<http://git.reviewboard.kde.org/r/112975/#comment30103>

    -t10 is ok.
    *but* if startup takes more time it will abort. It can take more time if there are pending changes in the WriteAheadLog that must be applyed before opening services. This can be many IO and fsync() and may take longer (but will be surprising)



server/src/storage/dbconfigpostgresql.cpp
<http://git.reviewboard.kde.org/r/112975/#comment30102>

    Extra argument can be added here to provide unix_socket_directory and maybe listen_adresses if it is preferable to keep setting it.



server/src/storage/dbconfigpostgresql.cpp
<http://git.reviewboard.kde.org/r/112975/#comment30104>

    it is way better to try a 
    "stop -m immediate"
    before having to go to SIGABRT (and it works on windows too, while I'm unsure about 'kill')
    


- Cédric  Villemain


On Sept. 28, 2013, 2:40 p.m., Cédric  Villemain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112975/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2013, 2:40 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> So the input/output are as expected.
> 
> 
> Diffs
> -----
> 
>   server/src/storage/dbconfigpostgresql.cpp acc65af149d0d4849dca535e9d0599e234befab2 
> 
> Diff: http://git.reviewboard.kde.org/r/112975/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cédric  Villemain
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/