[Kde-pim] Review Request 112976: Map QString to text instead of Bytea with PostgreSQL backend

[Cédric Villemain]

> On Sept. 28, 2013, 12:35 p.m., Dan Vrátil wrote:
> > server/src/storage/dbinitializer_p.cpp, line 283
> > <http://git.reviewboard.kde.org/r/112976/diff/1/?file=192933#file192933line283>
> >
> >     Could you elaborate the FIXME a bit more? :-)
> >     
> >     I remember you said we could/should use QSqlDriver::formatValue() so maybe you could resolve the FIXME right away and replace the code with it.setValue(driver.formatValue(....)) :-)
> 
> Cédric  Villemain wrote:
>     The FIXME is an hersazt of my code edition grabbed by git/reviewoard.
>     Tks for the example of usage.
>

It's not possible to formatValue here, the column type are unkown I think.
The whole replace is useless, it seems the only usage was to INSERT INTO flagTable ... ('\\SEEN') etc. and it should be '\SEEN', so the good fix is to just remove that.


- Cédric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112976/#review40949
-----------------------------------------------------------


On Sept. 28, 2013, 11:16 a.m., Cédric  Villemain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112976/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2013, 11:16 a.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> It's what suggested by QTSql.
> 
> It also happens to fix the recent issues raising around '\\SEEN' errors in SQL queries. It was visible because QTSql somewhat improve the postgresql driver, and so... akonadi revealed its own bug.
> 
> 
> Diffs
> -----
> 
>   server/src/storage/dbinitializer_p.cpp 55afaa9884df5cc1c3513907cbc3ac23785b0136 
>   server/src/storage/dbupdate.xml 2b1955e3e156b6dbe1a95759be1a6bbedd7c9732 
> 
> Diff: http://git.reviewboard.kde.org/r/112976/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cédric  Villemain
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/